Skip to content

Reflection#10

Merged
benjimaclellan merged 2 commits intomainfrom
reflection
Sep 19, 2025
Merged

Reflection#10
benjimaclellan merged 2 commits intomainfrom
reflection

Conversation

@yhteoh
Copy link
Contributor

@yhteoh yhteoh commented Sep 19, 2025

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    refactor

  • What is the current behavior? (You can also link to an open issue here)

  • type reflection attribute class_ is treated as a string
  • model_fields accessed via instance (slated for deprecation in pydantic v2.11)
  • What is the new behavior (if this is a feature change)?
  • type reflection attribute class_ is treated as a Literal
  • model_fields accessed via class
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

@yhteoh yhteoh marked this pull request as ready for review September 19, 2025 15:54
@benjimaclellan benjimaclellan merged commit bba1bb4 into main Sep 19, 2025
15 checks passed
@yhteoh yhteoh deleted the reflection branch December 15, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants