-
Notifications
You must be signed in to change notification settings - Fork 271
init.d/bootmisc: create /run/user #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
init.d/bootmisc.in
Outdated
| fi | ||
| else | ||
| extra=/var/run | ||
| extra=/var/run /var/run/user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing quoting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch
init.d/bootmisc.in
Outdated
| if [ "$RC_UNAME" = Linux ]; then | ||
| # Satisfy Linux FHS | ||
| extra=/var/lib/misc | ||
| if [ ! -d /var/run/user ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should stick to /run/user, not /var/run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
This is needed for some pam services that create the user XDG_RUNTIME_DIR. By example dumb_runtime_dir require the RUNTIME_DIR_PARENT to be present first.
|
Can I have some news about this? Its been some months and I still would like for this directory to exists thanks to openrc. |
|
This is an humble bump. Someone could give a review please? |
|
Happy 1 year birthday! |
|
Looks like alpine (unlike gentoo) doesn't really mandate a tmpfiles.d provider. Shame, since your usecase would've been much better served by it, something as simple as: $ cat /etc/tmpfiles.d/dumb-xdg.conf
d /run/user 0755 root root -But anyways, I kinda don't like this change. It'd be more acceptable (to me, at least) if bootmisc just accepted some additional list of dir from # conf.d/bootmisc
# ...
# additional directories to create, one per line, `-p` is implicit.
additional_mkdir="
-m 0755 /run/user
-m 1777 /tmp/mydir
"The arguments can just be fed to |
|
we could have something like "user:group perms /dir", and feed that to checkpath also i would argue that |
I don't think they would change their mind: ifreund/dumb_runtime_dir#5 (comment) |
|
Unless there are programs that hardcode It's perfectly acceptable to just do it as |
|
To be noted, dumb_runtime_dir has been patched in Alpine to use https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/81609 |
This is needed for some pam services that create the user XDG_RUNTIME_DIR. By example dumb_runtime_dir require the RUNTIME_DIR_PARENT to be present first.
Fixes: #658