Skip to content

Fix: Ensure the SVG container uses the full - space #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Ensure the SVG container uses the full - space #612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/app/services/analytics/origin-destination/components/origin-destination.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ export class OriginDestinationComponent implements OnInit, OnDestroy {
.append("svg")
.classed("main-origin-destination-container", true)
.attr("id", "main-origin-destination-container")
.attr("width", width)
.attr("height", height)
.attr("width", "100%")
.attr("height", "100%")
.attr("viewBox", `0 0 ${width} ${height}`);

const container = document.getElementById("main-origin-destination-container");
Expand Down Expand Up @@ -331,10 +331,13 @@ export class OriginDestinationComponent implements OnInit, OnDestroy {
},
onViewboxChanged: (viewboxProperties) => {
const svg = d3.select("#main-origin-destination-container");
svg.attr(
"viewBox",
`${viewboxProperties.panZoomLeft} ${viewboxProperties.panZoomTop} ${viewboxProperties.panZoomWidth} ${viewboxProperties.panZoomHeight}`,
);
svg
.attr(
"viewBox",
`${viewboxProperties.panZoomLeft} ${viewboxProperties.panZoomTop} ${viewboxProperties.panZoomWidth} ${viewboxProperties.panZoomHeight}`,
)
.attr("width", "100%")
.attr("height", "100%");
Comment on lines +338 to +340
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting width and height to '100%' on every viewbox change is redundant since these attributes don't change. Consider removing lines 339-340 from the onViewboxChanged callback as the dimensions are already set during initialization (lines 135-136).

Suggested change
)
.attr("width", "100%")
.attr("height", "100%");
);

Copilot uses AI. Check for mistakes.
},
onStartMultiSelect: () => {},
updateMultiSelect: () => {},
Expand Down