front, ui: upgrade ESLint to v9

front/package.json

@@ -96,7 +96,7 @@
   },
   "devDependencies": {
     "@apidevtools/swagger-parser": "^12.1.0",
-    "@eslint/js": "^8.57.1",
+    "@eslint/js": "^9.37.0",
     "@playwright/test": "^1.56.1",
     "@rtk-query/codegen-openapi": "^2.1.0",
     "@tailwindcss/postcss": "^4.1.16",
@@ -115,7 +115,7 @@
     "@vitejs/plugin-react-swc": "^4.2.0",
     "@vitest/eslint-plugin": "^1.4.0",
     "ansi-to-html": "^0.7.2",
-    "eslint": "^8.56.0",
+    "eslint": "^9.37.0",
     "eslint-config-prettier": "^10.1.5",
     "eslint-import-resolver-typescript": "^4.4.4",
     "eslint-plugin-import": "^2.31.0",

front/scripts/i18n-checker.ts

@@ -1,5 +1,3 @@
-/* eslint-disable no-console */
-
 import { readFile } from 'node:fs/promises';
 import path from 'node:path';
 

front/src/applications/editor/Editor.tsx

@@ -315,7 +315,6 @@ const Editor = () => {
     return () => {
       if (toolAndState.tool.onUnmount) toolAndState.tool.onUnmount(extendedContext);
     };
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [toolAndState.tool]);
 
   /**

front/src/applications/editor/Map.tsx

@@ -269,7 +269,7 @@ const MapUnplugged = ({
                       // instead. This fixes it:
                       entity = {
                         ...entity,
-                        // eslint-disable-next-line no-underscore-dangle,@typescript-eslint/no-explicit-any
+                        // eslint-disable-next-line @typescript-eslint/no-explicit-any
                         geometry: entity.geometry || (entity as any)._geometry,
                       };
                       activeTool.onClickEntity(entity, eventWithFeature, extendedContext);

front/src/applications/editor/tools/consts.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import type { CommonToolState } from './types';
 
 export const DEFAULT_COMMON_TOOL_STATE: CommonToolState = {

front/src/applications/editor/tools/pointEdition/components/PointEditionLayers.tsx

@@ -21,7 +21,6 @@ import { getEditorState } from 'reducers/editor/selectors';
 import { NULL_GEOMETRY } from 'types';
 
 type BasePointEditionLayersProps = {
-  // eslint-disable-next-line react/no-unused-prop-types
   map: Map;
   mergeEntityWithNearestPoint?: (
     entity: EditorEntity,

front/src/applications/editor/tools/pointEdition/consts.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line import/prefer-default-export
 export const POINT_LAYER_ID = 'pointEditionTool/new-entity';

front/src/applications/editor/tools/pointEdition/tool-factory.tsx

@@ -272,7 +272,6 @@ function getPointEditionTool<T extends EditorPoint>({
           typeof computedPosition === 'number' &&
           Math.abs(dbPosition - computedPosition) >= 1
         ) {
-          // eslint-disable-next-line no-console
           console.warn(
             `
       The entity ${entity.properties.id} position computed by Turf.js does not match the one from the database:

front/src/applications/editor/tools/rangeEdition/components/index.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line import/prefer-default-export
 export { default as RangeEditionLeftPanel } from './RangeEditionLeftPanel';

front/src/applications/editor/tools/rangeEdition/consts.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line import/prefer-default-export
 export const APPLICABLE_DIRECTIONS = ['BOTH', 'START_TO_STOP', 'STOP_TO_START'] as const;

front/src/applications/editor/tools/routeEdition/components/WayPointInput.tsx

@@ -112,7 +112,6 @@ const WayPointInput = ({ endPoint, wayPoint, onChange }: WayPointInputProps) =>
         onChange(null);
       }
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [wayPoint]);
 
   return (

front/src/applications/editor/tools/trackEdition/tool.tsx

@@ -339,7 +339,6 @@ const TrackEditionTool: Tool<TrackEditionState> = {
       }
 
       if (candidates.length === 1) {
-        // eslint-disable-next-line prefer-destructuring
         newState.nearestPoint = candidates[0];
       } else if (candidates.length > 1) {
         newState.nearestPoint = getNearestPoint(e.lngLat.toArray(), featureCollection(candidates));

front/src/applications/editor/tools/trackSplit/components/TrackSplitLeftPanel.tsx

@@ -76,7 +76,6 @@ const TrackSplitLeftPanel = () => {
             submit(state);
           }}
         >
-          {/* eslint-disable-next-line jsx-a11y/label-has-associated-control */}
           <label className="font-weight-medium" htmlFor="offset">
             {t('Editor.tools.track-split.offset.label')}
           </label>

front/src/applications/editor/tools/trackSplit/utils.ts

@@ -2,7 +2,6 @@ import { isNumber } from 'lodash';
 
 import type { TrackSectionEntity } from 'applications/editor/tools/trackEdition/types';
 
-// eslint-disable-next-line import/prefer-default-export
 export function isOffsetValid(offset: unknown, track: TrackSectionEntity): boolean {
   const trackLength = track.properties.length;
   return isNumber(offset) && offset > 0 && offset / 1000 < trackLength;

front/src/applications/operationalStudies/components/FilterTextField.tsx

@@ -26,7 +26,6 @@ export default function FilterTextField({ id, setFilter, sm = false, filterChips
 
   useEffect(() => {
     setFilter(debouncedFilter);
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [debouncedFilter]);
 
   return (

front/src/applications/operationalStudies/helpers/upsertMapWaypointsInOperationalPoints.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import type { TFunction } from 'i18next';
 
 import type { PathfindingResultSuccess, TrainSchedule } from 'common/api/osrdEditoastApi';

front/src/applications/operationalStudies/hooks/useScenario.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-asserted-optional-chain */
 import { useEffect, useMemo } from 'react';
 
 import { skipToken } from '@reduxjs/toolkit/query';

front/src/applications/operationalStudies/views/Scenario/components/ImportTimetableItem/generateTrainSchedulesPayloads.ts

@@ -1,5 +1,3 @@
-/* eslint-disable import/prefer-default-export */
-
 import { v4 as uuidV4 } from 'uuid';
 
 import type { GraouTrainSchedule } from 'common/api/graouApi';

front/src/applications/operationalStudies/views/Scenario/components/ManageTimetableItem/ManageTimetableItemMap/setPointIti.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import type { MapPathProperties } from 'applications/operationalStudies/types';
 import { insertViaFromMap } from 'reducers/osrdconf/helpers';
 import type { PathStep } from 'reducers/osrdconf/types';

front/src/applications/operationalStudies/views/Scenario/components/ManageTimetableItem/PacedTrainSettings/index.ts

@@ -1,2 +1 @@
-/* eslint-disable no-restricted-exports */
 export { default } from './PacedTrainSettings';

front/src/applications/operationalStudies/views/Scenario/components/ManageTimetableItem/PowerRestrictionsSelector/helpers/createPathStep.ts

@@ -31,7 +31,6 @@ export const cutRange = (
     ];
   }
 
-  // eslint-disable-next-line no-plusplus
   for (let i = 0; i < allRanges.length; i++) {
     // if the cut position is smaller than the current range begin, we insert new ranges before the current one
     if (allRanges[i].begin < newCutPosition && newCutPosition < allRanges[i].end) {

front/src/applications/operationalStudies/views/Scenario/components/ManageTimetableItem/consts.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line import/prefer-default-export
 export const MAX_TIMEWINDOW_MINUTES = 43800; // 1 month

front/src/applications/operationalStudies/views/Scenario/components/NGE/NGE.tsx

@@ -1,12 +1,12 @@
 import { useEffect, useRef, useState } from 'react';
 
-/* eslint-disable import/extensions, import/no-unresolved */
+/* eslint-disable import/extensions */
 import ngeMain from '@osrd-project/netzgrafik-frontend/dist/netzgrafik-frontend/main.js?url';
 import ngePolyfills from '@osrd-project/netzgrafik-frontend/dist/netzgrafik-frontend/polyfills.js?url';
 import ngeRuntime from '@osrd-project/netzgrafik-frontend/dist/netzgrafik-frontend/runtime.js?url';
 import ngeStyles from '@osrd-project/netzgrafik-frontend/dist/netzgrafik-frontend/styles.css?url';
 import ngeVendor from '@osrd-project/netzgrafik-frontend/dist/netzgrafik-frontend/vendor.js?url';
-/* eslint-enable import/extensions, import/no-unresolved */
+/* eslint-enable import/extensions */
 import { useTranslation } from 'react-i18next';
 
 import { EMPTY_DTO } from './consts';

front/src/applications/operationalStudies/views/Scenario/components/NGE/consts.ts

@@ -1,5 +1,3 @@
-/* eslint-disable import/prefer-default-export */
-
 import type { NetzgrafikDto } from './types';
 
 export const EMPTY_DTO: NetzgrafikDto = {

front/src/applications/operationalStudies/views/Scenario/components/Timetable/PacedTrain/OccurrenceIndicator.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable no-nested-ternary */
 import { useRef, useState } from 'react';
 
 import cx from 'classnames';

front/src/applications/operationalStudies/views/Scenario/consts.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/prefer-default-export
 export const MANAGE_TIMETABLE_ITEM_TYPES = Object.freeze({
   none: 'NONE',
   add: 'ADD',

front/src/applications/stdcm/components/StdcmHelpModule/SectionContentManager.tsx

@@ -18,7 +18,6 @@ const SectionContentManager = ({ content }: SectionContentManagerProps) => (
           );
 
         case 'text':
-          // eslint-disable-next-line react/no-danger
           return <p dangerouslySetInnerHTML={{ __html: content.value }} />;
         case 'faq':
           return (

front/src/applications/stdcm/components/StdcmResults/StdcmResultsTable.tsx

@@ -101,14 +101,11 @@ const StcdmResultsTable = ({
                         step.duration !== null && !isLastStep ? 'stop-with-duration ml-n2' : 'stop'
                       }
                     >
-                      {
-                        // eslint-disable-next-line no-nested-ternary
-                        isNotExtremity || !isRequestedPathStep
-                          ? step.duration !== null
-                            ? getStopDurationTime(step.duration)
-                            : step.time
-                          : ''
-                      }
+                      {isNotExtremity || !isRequestedPathStep
+                        ? step.duration !== null
+                          ? getStopDurationTime(step.duration)
+                          : step.time
+                        : ''}
                     </div>
                   </td>
                   <td className="stop">

front/src/common/BootstrapSNCF/InputGroupSNCF.tsx

@@ -170,7 +170,6 @@ export default function InputGroupSNCF<U extends string | MultiUnit>({
           </div>
         </div>
         {isDropdownShown && (
-          // eslint-disable-next-line jsx-a11y/control-has-associated-label
           <div
             style={{
               position: 'fixed',

front/src/common/Map/BaseMap.tsx

@@ -95,7 +95,6 @@ const BaseMap = ({
         pitch: parseFloat(urlPitch),
       });
     }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
 
   return (

front/src/common/Map/Layers/InfraObjectLayers/extensions/SNCF/PSL.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable react/jsx-pascal-case */
 import type { Geometry } from 'geojson';
 import type { TFunction } from 'i18next';
 import { isNil } from 'lodash';

front/src/common/Map/Search/consts.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line import/prefer-default-export
 export const MAIN_OP_CH_CODES = ['', '00', 'BV'];

front/src/common/Map/WarpedMap/DataLoader.tsx

@@ -103,7 +103,6 @@ const DataLoader = ({ bbox, getGeoJSONs, layers }: DataLoaderProps) => {
                       m
                         .querySourceFeatures('osm', { sourceLayer })
                         .map((f) => simplifyFeature(f, sourceLayer)),
-                      // eslint-disable-next-line no-plusplus
                       (f) => (f.id ? `osm-${f.id}` : `generated-${++incrementalID}`) // only deduplicate features with IDs
                     )
                   ),

front/src/common/Map/WarpedMap/core/grids.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable prefer-destructuring, no-plusplus */
 import bearing from '@turf/bearing';
 import center from '@turf/center';
 import destination from '@turf/destination';

front/src/common/Map/WarpedMap/core/helpers.ts

@@ -1,4 +1,3 @@
-/* eslint-disable prefer-destructuring, no-plusplus */
 import along from '@turf/along';
 import distance from '@turf/distance';
 import { point } from '@turf/helpers';
@@ -182,7 +181,6 @@ export function simplifyFeature(feature: GeoJSONFeature, sourceLayer?: string):
     type: 'Feature',
     id: feature.id,
     properties: { ...feature.properties, sourceLayer },
-    // eslint-disable-next-line no-underscore-dangle
     geometry: feature.geometry || feature._geometry,
   };
 }

front/src/common/Map/WarpedMap/core/projection.ts

@@ -1,4 +1,3 @@
-/* eslint-disable prefer-destructuring, no-plusplus */
 import type { Feature, FeatureCollection, Geometry, Position } from 'geojson';
 import { keyBy } from 'lodash';
 

front/src/common/Map/WarpedMap/core/quadtree.ts

@@ -1,4 +1,3 @@
-/* eslint-disable prefer-destructuring, no-plusplus */
 import bbox from '@turf/bbox';
 import type { Feature, FeatureCollection, GeoJsonProperties, Geometry, Position } from 'geojson';
 

front/src/common/Notifications/Notifications.tsx

@@ -33,7 +33,6 @@ const NotificationWrapper = (notif: Notification) => {
     return () => {
       clearTimer();
     };
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, []);
 
   return (

front/src/common/types.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/prefer-default-export
 export const DATA_TYPES = {
   string: 'STRING',
   date: 'DATE',

front/src/main/app.tsx

@@ -121,7 +121,6 @@ export default function App() {
   const dispatch = useAppDispatch();
 
   useEffect(() => {
-    // eslint-disable-next-line react-hooks/exhaustive-deps
     // Blindly dispatch current front version for storage
     dispatch(updateLastInterfaceVersion(import.meta.env.VITE_OSRD_GIT_DESCRIBE));
   }, []);

front/src/modules/infra/components/InfraSelector/InfraSelectorModalBodyEdition.tsx

@@ -145,7 +145,6 @@ const InfraSelectorModalBodyEdition = ({
           <div className="infra-add-import">
             {selectedFile ? (
               <>
-                {/* eslint-disable-next-line jsx-a11y/label-has-associated-control */}
                 <label className="infra-add-import-input-file with-file">
                   <VscJson />
                   <span className="ml-2" title={selectedFile.name}>
@@ -162,16 +161,13 @@ const InfraSelectorModalBodyEdition = ({
                 </button>
               </>
             ) : (
-              <>
-                {/* eslint-disable-next-line jsx-a11y/label-has-associated-control */}
-                <label className="infra-add-import-input-file">
-                  <VscJson />
-                  <span className="flex-grow-1 text-center">
-                    {t('infraManagement.addInfraJSONFile')}
-                  </span>
-                  <input type="file" onChange={handleSelect} accept=".json,.railjson" />
-                </label>
-              </>
+              <label className="infra-add-import-input-file">
+                <VscJson />
+                <span className="flex-grow-1 text-center">
+                  {t('infraManagement.addInfraJSONFile')}
+                </span>
+                <input type="file" onChange={handleSelect} accept=".json,.railjson" />
+              </label>
             )}
           </div>
           {isInfraLoading ? (

front/src/modules/powerRestriction/consts.ts

@@ -1,2 +1 @@
-// eslint-disable-next-line import/prefer-default-export
 export const NO_POWER_RESTRICTION = 'NO_POWER_RESTRICTION';

front/src/modules/rollingStock/helpers/powerRestrictions.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import { compact, uniq } from 'lodash';
 
 import type { RollingStock } from 'common/api/osrdEditoastApi';

front/src/modules/rollingStock/hooks/useFilterRollingStock.ts

@@ -194,7 +194,6 @@ const useFilterRollingStock = ({ isStdcm } = { isStdcm: false }) => {
       setFilteredRollingStockList(newFilteredRollingStock);
       setSearchIsLoading(false);
     }, 0);
-    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [filters, usefulRollingStocks]);
 
   return {

front/src/modules/simulationResult/components/SpeedDistanceDiagram/consts.ts

@@ -1,5 +1,3 @@
-/* eslint-disable import/prefer-default-export */
-
 export const electricalProfilesDesignValues = {
   '25000V': { color: 'rgb(228, 178, 132)', heightLevel: 0 },
   '22500V': { color: 'rgb(202, 149, 109)', heightLevel: 1 },

front/src/modules/simulationResult/components/SpeedDistanceDiagram/helpers.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import type {
   SpeedSpaceChartData,
   ElectricalProfileValues,

front/src/modules/timesStops/helpers/arrivalTime.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import { formatLocalTime } from 'utils/date';
 import { Duration, addDurationToDate } from 'utils/duration';
 import { calculateTimeDifferenceInDays } from 'utils/timeManipulation';

front/src/modules/timesStops/helpers/scheduleData.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import { Duration, addDurationToDate } from 'utils/duration';
 
 import type { ScheduleEntry } from '../types';

front/src/utils/constants.ts

@@ -1,6 +1,5 @@
 import { upperFirst, mapKeys } from 'lodash';
 
-// eslint-disable-next-line import/prefer-default-export
 export function makeEnumBooleans<T = symbol>(
   list: Record<string, T>,
   value: T | null

front/src/utils/duration.ts

@@ -1,5 +1,3 @@
-/* eslint-disable import/prefer-default-export */
-
 import dayjs from 'dayjs';
 // eslint-disable-next-line import/extensions
 import duration from 'dayjs/plugin/duration.js';

front/src/utils/geometry.ts

@@ -15,7 +15,6 @@ import { minBy } from 'lodash';
 
 import type { GeoJsonLineString } from 'common/api/osrdEditoastApi';
 
-// eslint-disable-next-line import/prefer-default-export
 export function getTangent(
   tangentPoint: Position,
   line: Feature<LineString>

front/src/utils/hooks/state.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import { useRef, useEffect } from 'react';
 
 export function usePrevious<T>(value: T) {

front/src/utils/object.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import { isEqual, pick } from 'lodash';
 /**
   compare two objects based on a list of keys

front/src/utils/selectors.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export */
 import { isNil } from 'lodash';
 
 import type { RootState } from 'reducers';