Fix OAEP source param #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
space88man
force-pushed
the
fix-oaep
branch
2 times, most recently
from
f4c96fd to
f0195de
Compare
Jakuje
reviewed
Mar 14, 2022
|
I am wondering why this is not caught by the tests that try the OAEP encryption. The softhsm should be checking for this since 2014. |
Sigh ... the check is there for encryption, wrapping, unwrapping, but not for decryption ... filled softhsm/SoftHSMv2#671 |
The only supported value is 1UL CKZ_DATA_SPECIFIED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only supported value for the source field of OAEP params is
1ULorCKZ_DATA_SPECIFIED.Some HSMs(Thales Luna) are strict about enforcing this and reject
0ULas an invalid mechanism.It could be that softhsm2 is more lenient about parsing this parameter.
Addresses #439
Update: indeed softhsm2 does not check this parameter for
CKZ_DATA_SPECIFIEDduring decryption