Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync problems. Experimental. DO NOT MERGE #2204

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Sync problems. Experimental. DO NOT MERGE #2204

wants to merge 6 commits into from

Conversation

evgenyz
Copy link
Contributor

@evgenyz evgenyz commented Mar 13, 2025 •
edited
Loading

Don't merge it!

  • E: oscap: DESC_WUNLOCK failed to unlock a mutex: Permission denied
  • E: oscap: DESC_WUNLOCK failed to unlock a mutex: Success
  • malloc_consolidate(): invalid chunk size (followed by Segmentation fault)

@evgenyz
Enable implicit locking for RBT operations
ac4d31b 
There are a lot of possible memory overruns reported by helgrind
coming from rbt_* operations without this flag.
evgenyz added 5 commits March 21, 2025 10:30
@evgenyz
Move probe_common_main's thread_barrier to the function scope
4836666 
We should not re-initialize thread_barrier, it is an UB.
@evgenyz
Do not use realloc(seap_msg->attrs, 0) to free seap_msg->attrs
0ebefaf 
This is implementation dependent, frown upon and triggering
for sanitizers.
@evgenyz
Add cleanup function for the probe_worker_runfn thread
793abe1 
We should make sure that receiver gets something (error should do it),
even if the worker thread suddenly terminates (e.g. thread_exit).
@evgenyz
Add predicate checks in the pthread_cond wait loop in seap-command.c
83147a5 
SEAP_cmd_exec function waiting branch was prone to spurious wakeups.
Use pthread_cond_broadcast __SEAP_cmd_sync_handler to make sure
all possible listeners are notified.
@evgenyz
Remove extra debugging logs in oscap_pcre.c
7a9b7a9 
These log records were introduced in anticipation of the
PCRE -> PCRE2 migration problems. We can get rid of them now.
@evgenyz evgenyz mentioned this pull request Mar 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@evgenyz