Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync problems. Experimental. DO NOT MERGE #2204

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Sync problems. Experimental. DO NOT MERGE #2204

wants to merge 3 commits into from

Conversation

evgenyz
Copy link
Contributor

@evgenyz evgenyz commented Mar 13, 2025

Don't merge it!

evgenyz added 3 commits March 13, 2025 22:26
@evgenyz
Move probe_common_main's thread_barrier to the function scope
fa29481 
We should not re-initialize thread_barrier, it is an UB.
@evgenyz
Do not use realloc(seap_msg->attrs, 0) to free seap_msg->attrs
7991d70 
This is implementation dependent, frown upon and triggering
for sanitizers.
@evgenyz
Add cleanup function for the probe_worker_runfn thread
486b051 
We should make sure that receiver gets something (error should do it),
even if the worker thread suddenly terminates (e.g. thread_exit).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@evgenyz