Fixing #5616 - NEEDS LOCAL TESTING - (Read description) - ColorPicker Select Screen Color #5619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vekhir
suggested changes
Sep 16, 2024
| @@ -41,7 +41,6 @@ def __init__(self, initial_color: QColor, callback, extra_options=0, | |||
| super().__init__(parent=parent, *args, **kwargs) | |||
| self.setObjectName("ColorPicker") | |||
| # Merge any additional user-supplied options with our own | |||
| options = QColorDialog.DontUseNativeDialog | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
src/windows/color_picker.py
Outdated
| @@ -53,7 +52,6 @@ def __init__(self, initial_color: QColor, callback, extra_options=0, | |||
| if title: | |||
| self.dialog.setWindowTitle(title) | |||
| self.dialog.setWindowFlags(Qt.Tool) | |||
| self.dialog.setOptions(options) | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Merge conflicts have been detected on this PR, please resolve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is simple, and removes the
DontUseNativeDialogoption from the color_picker.py file. This results in the program using the native pop-up color picker. I am running Ubuntu 24.04.1 and the colorpicker looks like this:Once you press the
+button, the pop-up changes to one where you can use the eyedropper tool.I have a feeling that using the native pop-up color picker might not be the most desirable solution, but it does work better than the current option.