add camera_framework(base on ov2640)#6
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a566e50e11
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| rt_base_t level = rt_hw_interrupt_disable(); | ||
| handle->capture.frame_ready = 1; | ||
| handle->capture.soi_found = 0; | ||
| handle->capture.enable_capture = 0; |
There was a problem hiding this comment.
Dispatch EOI-boundary JPEG frames
When a JPEG EOI marker is split across two DMA halves (0xFF as the previous byte and 0xD9 at source_ptr[0]), this branch marks the frame ready and clears enable_capture, but the only call to dvp_dispatch_frame() is inside the later while (index < half_size && handle->capture.enable_capture) loop. Because enable_capture is already 0, the loop is skipped, so single-shot reads time out and streaming drops/hangs for frames with this alignment. Dispatch the completed frame in this boundary branch or avoid clearing the flag before the existing dispatch path runs.
Useful? React with 👍 / 👎.
description in develop.md and READMD.md