fix(hex): avoid splitting on non-sector-aligned large gaps#50
Merged
HalfSweet merged 1 commit intoOpenSiFli:masterfrom Mar 3, 2026
Merged
fix(hex): avoid splitting on non-sector-aligned large gaps#50HalfSweet merged 1 commit intoOpenSiFli:masterfrom
HalfSweet merged 1 commit intoOpenSiFli:masterfrom
Conversation
Keep HEX data in one segment when a later block starts off 4KB boundary. For large gaps, only split at aligned sector starts; otherwise fill gap bytes with 0xFF. Also add regression tests for both hex parsing paths
HalfSweet
force-pushed
the
fix-hex-aligned
branch
from
35edbdd to
6283014
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep HEX data in one segment when a later block starts off 4KB boundary.
For large gaps, only split at aligned sector starts; otherwise fill gap bytes with 0xFF.
Also add regression tests for both hex parsing paths.