Skip to content

Conversation

@Dark-Existed
Copy link
Contributor

No description provided.

Copy link
Contributor

@Kyle-Ye Kyle-Ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is strange that your PR does not trigger the repo's workflow.

The macOS and Ubuntu is passing. But it will fail the compatibility test suite (which set OPENCOREGRAPHICS_COREGRAPHICS to 0 on macOS)

The error is

CGAffineTransformTests.swift:111:18: error: ambiguous use of 'init(a:b:c:d:tx:ty:)'

@Dark-Existed
Copy link
Contributor Author

It now works with the compatibility test suite.

@Kyle-Ye
Copy link
Contributor

Kyle-Ye commented Oct 13, 2025

I've triggered the pipeline check. And I'll give a final review and merge this week if possible.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.06%. Comparing base (5a96a88) to head (ba2cde3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   71.78%   73.06%   +1.27%     
==========================================
  Files           9       10       +1     
  Lines         638      672      +34     
==========================================
+ Hits          458      491      +33     
- Misses        180      181       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit 648592f into OpenSwiftUIProject:main Oct 19, 2025
@Kyle-Ye
Copy link
Contributor

Kyle-Ye commented Oct 19, 2025

Thanks 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants