Skip to content

Update UIHosting implementation to fix HostingExample example #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 16 commits into from
Feb 2, 2025

Fix id build issue

9472ae3
Select commit
Loading
Failed to load commit list.
Merged

Update UIHosting implementation to fix HostingExample example #187

Fix id build issue
9472ae3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 2, 2025 in 0s

22.16% (-0.31%) compared to 866bb21

View this Pull Request on Codecov

22.16% (-0.31%) compared to 866bb21

Details

Codecov Report

Attention: Patch coverage is 2.19780% with 267 lines in your changes missing coverage. Please review.

Project coverage is 22.16%. Comparing base (866bb21) to head (9472ae3).

Files with missing lines Patch % Lines
.../OpenSwiftUICore/View/Graph/ViewRendererHost.swift 0.00% 139 Missing ⚠️
.../Environment/EnvironmentKeyTransformModifier.swift 0.00% 19 Missing ⚠️
...SwiftUICore/View/Graph/EmptyViewRendererHost.swift 0.00% 19 Missing ⚠️
...tform/HostingViewTransparentBackgroundReason.swift 0.00% 15 Missing ⚠️
Sources/OpenSwiftUI/View/List/EditMode.swift 0.00% 14 Missing ⚠️
Sources/OpenSwiftUICore/View/Graph/ViewGraph.swift 0.00% 12 Missing ⚠️
...iftUICore/Data/Environment/EnvironmentValues.swift 8.33% 11 Missing ⚠️
...gration/Hosting/Platform/HostingViewProtocol.swift 0.00% 10 Missing ⚠️
Sources/OpenSwiftUICore/Graph/GraphInputs.swift 0.00% 10 Missing ⚠️
Sources/OpenSwiftUI/CoreGlue/OpenSwiftUIGlue.swift 0.00% 4 Missing ⚠️
... and 8 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   22.46%   22.16%   -0.31%     
==========================================
  Files         295      299       +4     
  Lines       10972    11141     +169     
==========================================
+ Hits         2465     2469       +4     
- Misses       8507     8672     +165

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov