-
Notifications
You must be signed in to change notification settings - Fork 58
Add ORBPath integration #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #680 +/- ##
===========================================
+ Coverage 13.82% 28.46% +14.63%
===========================================
Files 559 585 +26
Lines 32559 35480 +2921
===========================================
+ Hits 4502 10099 +5597
+ Misses 28057 25381 -2676 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🤖 Augment PR SummarySummary: This PR integrates ORBPath/RenderBox-backed path handling into OpenSwiftUI’s core Changes:
Technical Notes: The implementation relies on unsafe buffer layout compatibility between Swift/C unions and ORBPath storage callbacks, and gates behavior by platform and 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| kind = .cgPath | ||
| //data = PathData(path) | ||
| _openSwiftUIUnimplementedFailure() | ||
| data = PathData(cgPath: .passUnretained(path)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| let storage = withUnsafeMutablePointer(to: &box.data) { | ||
| unsafeBitCast($0, to: ORBPath.Storage.self) | ||
| } | ||
| return storage.isEmpty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.