Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 3, 2026

No description provided.

@augmentcode
Copy link

augmentcode bot commented Jan 3, 2026

🤖 Augment PR Summary

Summary: Introduces a UIKit “update cycle” integration point so OpenSwiftUI can run work right before UIKit’s CATransaction commit.

Changes:

  • Extends UIKit_Private.h with additional UIKitCore private UIUpdate-cycle symbols (enabled check, timing structs, and sequence item insertion/removal APIs).
  • Adds UIKitUpdateCycle (iOS/visionOS) to register pre-commit observers via _UIUpdateSequenceInsertItem and execute queued actions under Update.perform.
  • Promotes Update.perform to package visibility so it can be invoked from the OpenSwiftUI target.

Technical Notes: The pre-commit hook is registered once (static token) and drains an in-memory action queue on each callback.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@Kyle-Ye Kyle-Ye force-pushed the feature/update_cycle branch from 75226e1 to da3e595 Compare January 3, 2026 12:15
@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 14.29%. Comparing base (c3a3efb) to head (57bb397).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Sources/OpenSwiftUICore/Data/Update.swift 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c3a3efb) and HEAD (57bb397). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (c3a3efb) HEAD (57bb397)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #704       +/-   ##
===========================================
- Coverage   28.75%   14.29%   -14.46%     
===========================================
  Files         589      563       -26     
  Lines       35836    33190     -2646     
===========================================
- Hits        10303     4743     -5560     
- Misses      25533    28447     +2914     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit f04794e into main Jan 3, 2026
5 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/update_cycle branch January 3, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants