Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 3, 2026

No description provided.

The old implementation will make preferencesChanged is always true and mainUpdates &-= 1 is always triggered.

In the end, ViewGraph.updateRequiredMainThread will always be false.
@augmentcode
Copy link

augmentcode bot commented Jan 3, 2026

🤖 Augment PR Summary

Summary: Fixes issues in the async rendering/update pipeline by ensuring render-host state is sourced consistently and by tightening preference-change detection.

Changes:

  • Move `_UIHostingView`’s `ViewRendererHost` state (`currentTimestamp`, `propertiesNeedingUpdate`, etc.) to forward into `UIHostingViewBase`.
  • Route async-render follow-up scheduling through `host.requestUpdate(after:)` from `UIHostingViewBase`.
  • Adjust `GraphHost.updatePreferences()` to only report changes when preference seeds actually differ.

Technical Notes: This reduces redundant updates and aligns async rendering timing/state with the underlying base host implementation.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

@Kyle-Ye Kyle-Ye merged commit c6e6fbd into main Jan 3, 2026
5 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the bugfix/async_render branch January 3, 2026 20:04
@codecov
Copy link

codecov bot commented Jan 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 28.83%. Comparing base (874ef85) to head (f0f63ae).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
- Coverage   28.87%   28.83%   -0.04%     
==========================================
  Files         589      589              
  Lines       35837    35837              
==========================================
- Hits        10347    10333      -14     
- Misses      25490    25504      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants