Fix incorrect wayland session detection faq

[NoraPerry]

The current suggested fix doesn't work as I believe :0 is a X11 thing. For wayland it should be wayland-0 (or a number other than 0).

I've used ExecStart instead of Environment because that's the only way to get systemd to expand the variable.

[X9VoiD]

Is there a reason for this empty extra ExecStart?

[NoraPerry]

The empty ExecStart is to clear the value. Otherwise when you run it, it will run both the default start command and the custom one which makes it throw an error.

[InfinityGhost]

That's pretty weird behavior, makes me wonder if that's what it's supposed to do.

[X9VoiD]

Should probably change it to ExecStart=/usr/bin/env sh -c "WAYLAND_DISPLAY=$WAYLAND_DISPLAY /usr/bin/otd".

Not sure if doing the same for invoking otd is better but this thing above is at least an improvement as it removes explicit /bin/bash dependency.

[cidkidnix]

Ideally OTD should detect the socket by itself. My issue with this PR is that it assumes that every user-unit in systemd inherits the user environment.

[cidkidnix]

Also could stick with the original method of doing it but telling users to run ls /run/user/$UID/ | grep wayland and taking the wayland socket name from there

[NoraPerry]

Changed to use /usr/bin/env. I tested and if you run it like that it can get the env var normally so I've removed the manual setting.

[NoraPerry]

Also could stick with the original method of doing it but telling users to run ls /run/user/$UID/ | grep wayland and taking the wayland socket name from there

Wouldn't they have to do this again if the socket changes though? The reason I'm making this pr is because I originally had mine set to wayland-0 then my pc changed it to wayland-1 at some point so the config broke.

[gonX]

#43 ?

[cidkidnix]

Also could stick with the original method of doing it but telling users to run ls /run/user/$UID/ | grep wayland and taking the wayland socket name from there

Wouldn't they have to do this again if the socket changes though? The reason I'm making this pr is because I originally had mine set to wayland-0 then my pc changed it to wayland-1 at some point so the config broke.

This was probably due to wlroots switching from wayland-0 to wayland-1 assuming you're on a wlroots-based compositor

[NoraPerry]

#43 ?

Yeah the graphical-session dependency seems like a better long term solution than my thing.
Will try it out when I have free time.

[InfinityGhost]

Marked as draft due to a potentially better solution.