This repository was archived by the owner on Nov 18, 2024. It is now read-only.
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #46 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 22
Lines ? 1495
Branches ? 0
=====================================
Hits ? 0
Misses ? 1495
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
Changes look good, just need to resolve build test failures; not sure if we want to keep those failing tests; it seems a bug in upstream dependencies is causing failure |
Member
Author
|
merging since build tests pass in py3.8 and only fail 3.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
companion PR to OpenVoiceOS/ovos-backend-client#24