fix(i18n): normalize locale folders to canonical BCP-47 by JarbasAl · Pull Request #113 · OpenVoiceOS/ovos-skill-volume

JarbasAl · 2026-04-04T04:37:03Z

Summary

Normalize all locale folder names to canonical BCP-47 form (e.g. da-dk → da-DK, da → da-DK)
Merge duplicate locale directories that differ only in case
Remove nested bare-language subdirectories (e.g. eu-ES/eu/ → eu-ES/)
Fixes wheel/sdist build failures: ZIP file contains multiple entries with different contents

Test plan

Verify pip install . / uv pip install . builds without ZIP duplicate errors
Verify locale files load correctly at runtime

🤖 Generated with Claude Code

Rename all locale directories to use canonical BCP-47 codes: - Lowercase regions → uppercase (da-dk → da-DK, en-us → en-US) - Bare language codes → full BCP-47 (da → da-DK, eu → eu-ES) - Invalid codes remapped (eu-eu → eu-ES, fa-fa → fa-IR) - Nested bare-language subdirs merged up (eu-ES/eu/ → eu-ES/) This fixes wheel build failures caused by ZIP files containing duplicate entries with different contents for the same logical path. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

coderabbitai · 2026-04-04T04:37:10Z

Important

Review skipped

Too many files!

This PR contains 216 files, which is 66 over the limit of 150.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2799cc26-151c-4827-bd25-387f5522607f

📥 Commits

Reviewing files that changed from the base of the PR and between 6a223d1 and 7025bfd.

📒 Files selected for processing (216)

locale/ca-es/change.voc
locale/ca-es/current.voc
locale/ca-es/error.get.volume.dialog
locale/ca-es/louder.voc
locale/ca-es/quieter.voc
locale/ca-es/volume.change.amount.dialog
locale/ca-es/volume.current.dialog
locale/ca-es/volume.default.intent
locale/ca-es/volume.high.intent
locale/ca-es/volume.low.intent
locale/ca-es/volume.max.already.dialog
locale/ca-es/volume.max.dialog
locale/ca-es/volume.max.intent
locale/ca-es/volume.mute.intent
locale/ca-es/volume.mute.toggle.intent
locale/ca-es/volume.set.percent.dialog
locale/ca-es/volume.unmute.intent
locale/ca-es/volume.voc
locale/da-dk/change.voc
locale/da-dk/current.voc
locale/da-dk/error.get.volume.dialog
locale/da-dk/louder.voc
locale/da-dk/quieter.voc
locale/da-dk/volume.change.amount.dialog
locale/da-dk/volume.current.dialog
locale/da-dk/volume.default.intent
locale/da-dk/volume.high.intent
locale/da-dk/volume.low.intent
locale/da-dk/volume.max.already.dialog
locale/da-dk/volume.max.dialog
locale/da-dk/volume.max.intent
locale/da-dk/volume.mute.intent
locale/da-dk/volume.mute.toggle.intent
locale/da-dk/volume.set.percent.dialog
locale/da-dk/volume.unmute.intent
locale/da-dk/volume.voc
locale/de-de/change.voc
locale/de-de/current.voc
locale/de-de/error.get.volume.dialog
locale/de-de/louder.voc
locale/de-de/quieter.voc
locale/de-de/volume.change.amount.dialog
locale/de-de/volume.current.dialog
locale/de-de/volume.default.intent
locale/de-de/volume.high.intent
locale/de-de/volume.low.intent
locale/de-de/volume.max.already.dialog
locale/de-de/volume.max.dialog
locale/de-de/volume.max.intent
locale/de-de/volume.mute.intent
locale/de-de/volume.mute.toggle.intent
locale/de-de/volume.set.percent.dialog
locale/de-de/volume.unmute.intent
locale/de-de/volume.voc
locale/en-us/change.voc
locale/en-us/current.voc
locale/en-us/error.get.volume.dialog
locale/en-us/louder.voc
locale/en-us/quieter.voc
locale/en-us/volume.change.amount.dialog
locale/en-us/volume.current.dialog
locale/en-us/volume.default.intent
locale/en-us/volume.high.intent
locale/en-us/volume.low.intent
locale/en-us/volume.max.already.dialog
locale/en-us/volume.max.dialog
locale/en-us/volume.max.intent
locale/en-us/volume.mute.intent
locale/en-us/volume.mute.toggle.intent
locale/en-us/volume.set.percent.dialog
locale/en-us/volume.unmute.intent
locale/en-us/volume.voc
locale/es-es/change.voc
locale/es-es/current.voc
locale/es-es/error.get.volume.dialog
locale/es-es/louder.voc
locale/es-es/quieter.voc
locale/es-es/volume.change.amount.dialog
locale/es-es/volume.current.dialog
locale/es-es/volume.default.intent
locale/es-es/volume.high.intent
locale/es-es/volume.low.intent
locale/es-es/volume.max.already.dialog
locale/es-es/volume.max.dialog
locale/es-es/volume.max.intent
locale/es-es/volume.mute.intent
locale/es-es/volume.mute.toggle.intent
locale/es-es/volume.set.percent.dialog
locale/es-es/volume.unmute.intent
locale/es-es/volume.voc
locale/eu/change.voc
locale/eu/current.voc
locale/eu/error.get.volume.dialog
locale/eu/louder.voc
locale/eu/quieter.voc
locale/eu/volume.change.amount.dialog
locale/eu/volume.current.dialog
locale/eu/volume.default.intent
locale/eu/volume.high.intent
locale/eu/volume.low.intent
locale/eu/volume.max.already.dialog
locale/eu/volume.max.dialog
locale/eu/volume.max.intent
locale/eu/volume.mute.intent
locale/eu/volume.mute.toggle.intent
locale/eu/volume.set.percent.dialog
locale/eu/volume.unmute.intent
locale/eu/volume.voc
locale/fr-fr/change.voc
locale/fr-fr/current.voc
locale/fr-fr/error.get.volume.dialog
locale/fr-fr/louder.voc
locale/fr-fr/quieter.voc
locale/fr-fr/volume.change.amount.dialog
locale/fr-fr/volume.current.dialog
locale/fr-fr/volume.default.intent
locale/fr-fr/volume.high.intent
locale/fr-fr/volume.low.intent
locale/fr-fr/volume.max.already.dialog
locale/fr-fr/volume.max.dialog
locale/fr-fr/volume.max.intent
locale/fr-fr/volume.mute.intent
locale/fr-fr/volume.mute.toggle.intent
locale/fr-fr/volume.set.percent.dialog
locale/fr-fr/volume.unmute.intent
locale/fr-fr/volume.voc
locale/gl-es/change.voc
locale/gl-es/current.voc
locale/gl-es/error.get.volume.dialog
locale/gl-es/louder.voc
locale/gl-es/quieter.voc
locale/gl-es/volume.change.amount.dialog
locale/gl-es/volume.current.dialog
locale/gl-es/volume.default.intent
locale/gl-es/volume.high.intent
locale/gl-es/volume.low.intent
locale/gl-es/volume.max.already.dialog
locale/gl-es/volume.max.dialog
locale/gl-es/volume.max.intent
locale/gl-es/volume.mute.intent
locale/gl-es/volume.mute.toggle.intent
locale/gl-es/volume.set.percent.dialog
locale/gl-es/volume.unmute.intent
locale/gl-es/volume.voc
locale/it-it/change.voc
locale/it-it/current.voc
locale/it-it/error.get.volume.dialog
locale/it-it/louder.voc
locale/it-it/quieter.voc
locale/it-it/volume.change.amount.dialog
locale/it-it/volume.current.dialog
locale/it-it/volume.default.intent
locale/it-it/volume.high.intent
locale/it-it/volume.low.intent
locale/it-it/volume.max.already.dialog
locale/it-it/volume.max.dialog
locale/it-it/volume.max.intent
locale/it-it/volume.mute.intent
locale/it-it/volume.mute.toggle.intent
locale/it-it/volume.set.percent.dialog
locale/it-it/volume.unmute.intent
locale/it-it/volume.voc
locale/nl-nl/change.voc
locale/nl-nl/current.voc
locale/nl-nl/error.get.volume.dialog
locale/nl-nl/louder.voc
locale/nl-nl/quieter.voc
locale/nl-nl/volume.change.amount.dialog
locale/nl-nl/volume.current.dialog
locale/nl-nl/volume.default.intent
locale/nl-nl/volume.high.intent
locale/nl-nl/volume.low.intent
locale/nl-nl/volume.max.already.dialog
locale/nl-nl/volume.max.dialog
locale/nl-nl/volume.max.intent
locale/nl-nl/volume.mute.intent
locale/nl-nl/volume.mute.toggle.intent
locale/nl-nl/volume.set.percent.dialog
locale/nl-nl/volume.unmute.intent
locale/nl-nl/volume.voc
locale/pt-br/change.voc
locale/pt-br/current.voc
locale/pt-br/error.get.volume.dialog
locale/pt-br/louder.voc
locale/pt-br/quieter.voc
locale/pt-br/volume.change.amount.dialog
locale/pt-br/volume.current.dialog
locale/pt-br/volume.default.intent
locale/pt-br/volume.high.intent
locale/pt-br/volume.low.intent
locale/pt-br/volume.max.already.dialog
locale/pt-br/volume.max.dialog
locale/pt-br/volume.max.intent
locale/pt-br/volume.mute.intent
locale/pt-br/volume.mute.toggle.intent
locale/pt-br/volume.set.percent.dialog
locale/pt-br/volume.unmute.intent
locale/pt-br/volume.voc
locale/pt-pt/change.voc
locale/pt-pt/current.voc
locale/pt-pt/error.get.volume.dialog
locale/pt-pt/louder.voc
locale/pt-pt/quieter.voc
locale/pt-pt/volume.change.amount.dialog
locale/pt-pt/volume.current.dialog
locale/pt-pt/volume.default.intent
locale/pt-pt/volume.high.intent
locale/pt-pt/volume.low.intent
locale/pt-pt/volume.max.already.dialog
locale/pt-pt/volume.max.dialog
locale/pt-pt/volume.max.intent
locale/pt-pt/volume.mute.intent
locale/pt-pt/volume.mute.toggle.intent
locale/pt-pt/volume.set.percent.dialog
locale/pt-pt/volume.unmute.intent
locale/pt-pt/volume.voc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/locales

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-04-04T04:37:57Z

Beep! Your PR results are served. 🍽️

I've aggregated the results of the automated checks for this PR below.

🔍 Lint

Checking if there's anything else we need to do. 📋

❌ ruff: issues found — see job log

🏷️ Release Preview

Ensuring the 'Dependency Updates' are documented. 📦

Current: 0.1.20a2 → Next: 0.1.20a3

Signal	Value
Label	(none)
PR title	`fix(i18n): normalize locale folders to canonical BCP-47`
Bump	alpha

⚠️ No conventional commit prefix — alpha-only bump.
Suggested: fix: update the thing or feat: update the thing

🚀 Release Channel Compatibility

Predicted next version: 0.1.20a3

Channel	Status	Note	Current Constraint
Stable	✅	Compatible	`ovos-skill-volume>=0.1.16,<0.2.0`
Testing	✅	Compatible	`ovos-skill-volume>=0.1.16,<1.0.0`
Alpha	✅	Compatible	`ovos-skill-volume>=0.1.17a6`

🎙️ Skill

Skill inspection report: All systems go! 🚀

🎙️ (unknown skill_id) — 13 languages

❌ en-us locale not found

Gitlocalize: ❌ sync script · ✅ translations/ · ❌ sync workflow

⚖️ License Check

Verifying the origin of all contributed code. 🌍

✅ No license violations found (50 packages).

License distribution: 12× MIT License, 8× MIT, 7× Apache Software License, 7× Apache-2.0, 2× BSD-3-Clause, 2× ISC License (ISCL), 2× PSF-2.0, 2× Python Software Foundation License, +7 more

Full breakdown — 50 packages

Package	Version	License	URL
`audioop-lts`	0.2.2	PSF-2.0	link
`build`	1.4.2	MIT	link
`certifi`	2026.2.25	Mozilla Public License 2.0 (MPL 2.0)	link
`charset-normalizer`	3.4.7	MIT	link
`click`	8.3.2	BSD-3-Clause	link
`combo_lock`	0.3.1	Apache-2.0	link
`filelock`	3.25.2	MIT	link
`ftfy`	6.3.1	Apache-2.0	link
`idna`	3.11	BSD-3-Clause	link
`importlib_metadata`	9.0.0	Apache-2.0	link
`json-database`	0.10.1	MIT	link
`kthread`	0.2.3	MIT License	link
`langcodes`	3.5.1	MIT License	link
`markdown-it-py`	4.0.0	MIT License	link
`mdurl`	0.1.2	MIT License	link
`memory-tempfile`	2.2.3	MIT License	link
`ovos-config`	2.1.1	Apache-2.0	link
`ovos-number-parser`	0.5.1	Apache Software License	link
`ovos-plugin-manager`	2.2.0	Apache-2.0	link
`ovos-skill-volume`	0.1.20a2	Apache-2.0	link
`ovos-solver-yes-no-plugin`	0.2.8	MIT	link
`ovos-utils`	0.8.5	Apache-2.0	link
`ovos-utterance-normalizer`	0.2.3	Apache Software License	link
`ovos_bus_client`	1.5.0	Apache Software License	link
`ovos_workshop`	8.0.0	apache-2.0	link
`packaging`	26.0	Apache-2.0 OR BSD-2-Clause	link
`padacioso`	1.0.0	apache-2.0	link
`pexpect`	4.9.0	ISC License (ISCL)	link
`ptyprocess`	0.7.0	ISC License (ISCL)	link
`pyee`	12.1.1	MIT License	link
`Pygments`	2.20.0	BSD-2-Clause	link
`pyproject_hooks`	1.2.0	MIT License	link
`python-dateutil`	2.9.0.post0	Apache Software License; BSD License	link
`PyYAML`	6.0.3	MIT License	link
`quebra-frases`	0.3.7	Apache Software License	link
`RapidFuzz`	3.14.3	MIT	link
`regex`	2026.4.4	Apache-2.0 AND CNRI-Python	link
`requests`	2.33.1	Apache Software License	link
`rich`	13.9.4	MIT License	link
`rich-click`	1.9.7	MIT License

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🚌 Bus Coverage

Measuring the reach of our bus handlers. 📏

⚠️ Bus coverage report unavailable — check the job log.

📋 Repo Health

Ensuring the project's documentation is healthy. 📚

✅ All required files present.

Latest Version: 0.1.20a2

✅ version.py — Version file
✅ README.md — README
✅ LICENSE — License file
⚠️ pyproject.toml — pyproject.toml
✅ setup.py — setup.py
✅ CHANGELOG.md — Changelog
✅ requirements.txt — Requirements
✅ version.py has valid version block markers

📊 Coverage

A bird's eye view of your test coverage landscape. 🦅

⚠️ Coverage data unavailable — check the job log.

⚠️ Some tests failed — coverage figures may be incomplete.

🔒 Security (pip-audit)

The security sentinel has finished its patrol. 💂‍♂️

✅ No known vulnerabilities found (70 packages scanned).

🔨 Build Tests

A thorough inspection of the build process. 🔍

Python	Build	Install	Tests
3.10	❌	⊘	⊘
3.11	❌	⊘	⊘
3.12	❌	⊘	⊘
3.13	❌	⊘	⊘
3.14	❌	⊘	⊘

❌ 3.10: python -m build failed
❌ 3.11: python -m build failed
❌ 3.12: python -m build failed
❌ 3.13: python -m build failed
❌ 3.14: python -m build failed
Check job logs for details.

Transmitted from the OVOS mothership. 🛸

github-actions Bot added the fix label Apr 4, 2026

JarbasAl merged commit 27b8ecf into dev Apr 4, 2026
8 of 16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(i18n): normalize locale folders to canonical BCP-47#113

fix(i18n): normalize locale folders to canonical BCP-47#113
JarbasAl merged 1 commit intodevfrom
fix/locales

JarbasAl commented Apr 4, 2026

Uh oh!

coderabbitai Bot commented Apr 4, 2026

Review skipped

Uh oh!

github-actions Bot commented Apr 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

JarbasAl commented Apr 4, 2026

Summary

Test plan

Uh oh!

coderabbitai Bot commented Apr 4, 2026

Review skipped

Uh oh!

github-actions Bot commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Beep! Your PR results are served. 🍽️

🔍 Lint

🏷️ Release Preview

🎙️ Skill

⚖️ License Check

🚌 Bus Coverage

📋 Repo Health

📊 Coverage

🔒 Security (pip-audit)

🔨 Build Tests

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Apr 4, 2026 •

edited

Loading