Skip to content

fix: only play last one effect #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiaoxustudio wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: only play last one effect #794

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd6a1ed
fix: only play last one effect
xiaoxustudio Oct 31, 2025
f675f9c
fix: remove useless code
xiaoxustudio Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/webgal/src/Core/gameScripts/playEffect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { IPerform } from '@/Core/Modules/perform/performInterface';
import { useSelector } from 'react-redux';
import { WebGAL } from '@/Core/WebGAL';
import { WEBGAL_NONE } from '@/Core/constants';
import { uniqueId } from 'lodash';

/**
* 播放一段效果音
Expand All @@ -15,7 +16,7 @@ export const playEffect = (sentence: ISentence): IPerform => {
logger.debug('play SE');
// 如果有ID，这里被覆写，一般用于循环的情况
// 有循环参数且有 ID，就循环
let performInitName = 'effect-sound';
let performInitName = `effect-sound-${uniqueId()}`;
Comment thread
xiaoxustudio marked this conversation as resolved.
// 清除先前的效果音
WebGAL.gameplay.performController.unmountPerform(performInitName, true);
let url = sentence.content;
Expand Down