Skip to content

fix: 修复非官方引擎在 build 时版本号被错误覆盖的问题 #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boomwwww wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: 修复非官方引擎在 build 时版本号被错误覆盖的问题 #940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/webgal/scripts/update-engine-version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,10 @@ try {
const engineJson = JSON.parse(fs.readFileSync(engineJsonPath, 'utf-8'));

// 更新版本号
const oldVersion = engineJson.version;
engineJson.version = version;
const oldVersion = engineJson.webgalVersion;
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

oldVersion 现在被赋值为 engineJson.webgalVersion。如果该字段在 engine.json 中不存在（例如在旧版本的引擎中），oldVersion 将会是 undefined。这可能会导致后续的日志输出不够清晰。建议增加回退到 engineJson.version 的逻辑。

Suggested change
const oldVersion = engineJson.webgalVersion;
const oldVersion = engineJson.webgalVersion || engineJson.version;

if (engineJson.type === 'official') {
engineJson.version = version;
}
engineJson.webgalVersion = version;

// 写回文件（保持格式化）
Expand Down
Loading