Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): refactor ODD protocol card copy when run data is not "ok" #17261

Open
wants to merge 1 commit into
base: chore_release-8.3.0
Choose a base branch
from

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Jan 14, 2025

Closes RQA-3851

Overview

When protocol cards have not ok run data, we can't retrieve the completedAt timestamp, and the fallback has been the current date, which is confusing copy. After speaking with Design, the plan is to remove copy if we can't retrieve the completedAt timestamp.

As an aside, I did investigate the suffix comment left in the code. After playing around with it a bit and reading the docs, turns out we do need to keep suffix: true.

Screenshot 2025-01-14 at 10 09 21 AM

Test Plan and Hands on Testing

  • See pic.

Changelog

  • ODD recently run protocol cards no longer show the current time when the last run completed time is unknown.

Risk assessment

very low

@mjhuff mjhuff requested a review from a team as a code owner January 14, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant