refactor(app): refactor ODD protocol card copy when run data is not "ok" #17261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3851
Overview
When protocol cards have not ok run data, we can't retrieve the
completedAt
timestamp, and the fallback has been the current date, which is confusing copy. After speaking with Design, the plan is to remove copy if we can't retrieve thecompletedAt
timestamp.As an aside, I did investigate the
suffix
comment left in the code. After playing around with it a bit and reading the docs, turns out we do need to keepsuffix: true
.Test Plan and Hands on Testing
Changelog
Risk assessment
very low