-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(protocol-designer): update logic to add modules and fixtures with plate reader #17344
Conversation
… plate reader update logic to add modules and fixtures with plate reader and align ui with the latest design close AUTH-1287
@@ -221,6 +220,9 @@ export function SelectModules(props: WizardTileProps): JSX.Element | null { | |||
gridGap={SPACING.spacing4} | |||
> | |||
{Object.entries(modules) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use .values()
if we aren't using the properties here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not using .values()
because of type errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected. Seeing that you added tests for edge cases, I feel comfortable with this. One note: it is possible to skip module addition, then add 4x staging areas, then go back and add a plate reader, and the staging area quantity still reads 4, even though only 3 are added. Do you think this is worth addressing?
good catch. https://opentrons.slack.com/archives/C0866FUHXGQ/p1738017159079279 |
Overview
update logic to add modules and fixtures with plate reader and align ui with the latest design
3
because of the above requirements. available slots are A3 (because trash bin can be placed column 1 slots), C3, D3design
the related thread
https://opentrons.slack.com/archives/C0866FUHXGQ/p1737665141057879
close AUTH-1287
Test Plan and Hands on Testing
3
deck view displays plate reader on B3, 3 staging areas and trash bin is on A1if staging area's quantity is 1 or 2, plate reader on B3, trash bin on A3, and staging areas on C3 and D3
4
and deck view displays 4 staging areas and trash bin is on A1Changelog
Review requests
Risk assessment
mid since this PR modify the logic for module selection and fixture selection