fix(labware-library): labware creator adapter z offset fit

[alexjoel42]

Overview

Addressing a customer reported bug where labware's stacked offsets while loaded onto just a module don't account for the module's height.

Also closes https://opentrons.atlassian.net/browse/RESC-382

Test Plan and Hands on Testing

Make custom labware using the module's hights and then check the offsets

Changelog

One line change

Review requests

I want to verify that this doesn't have any wider scope code risk. I don't understand Labware-Creator very well as an ecosystem yet.

Risk assessment

Medium

[jerader]

does this get us the right number if you smoke test it? make -C labware-library dev launches the labware-library dev environment.

[alexjoel42]

fields.labwareZDimension -
 parseFloat(String(z)) +
moduleDefinition.dimensions.bareOverallHeight,

I tested it in an example and so far so good!
thermobareoverall_96_wellplate_2000ul.json

1. fields.labwareZDimension = 43
2. Total Height (in this case parseFloat String(z) ) = 55
3. moduleDefinition.dimensions.bareOverallHeight = 45

Stacking Offset should equal 33.

Going to review with @sanni-t how to best test

[alexjoel42]

I think we're in good shape though.

fields.labwareZDimension -
 parseFloat(String(z)) +
moduleDefinition.dimensions.bareOverallHeight,

fields.labwareZDimension = 10
parseFloat(String(z)) = 108
moduleDefinition.dimensions.bareOverallHeight = 108.96

Stacking offset with module "z": 10.959999999999994

Which is close enough!

tcreservoirtest_96_reservoir_111ul.json

I think we're in good shape. Probably going to push tomorrow so I can focus on robot stack.

[jerader]

Awesome! Ya, feel free to merge in whenever, now that you tested it 🙌

[alexjoel42]

edit: The plot did not thicken. I was was measuring wrong. All is well and we can push this out. for posterity. I have exchanged moduleDefinition.dimensions.bareOverallHeight for moduleDefinition.labwareOffset.z which is more accurate.

[jerader]

code looks correct, just want to double check that we smoke test it and that the offset is what we would expect!

Some nits:

1. please title this PR pydantically so: fix(labware-library): labware creator adapter z offset fit or something like that
2. you have no way of knowing this so don't worry but we like to name our branches like projectName_short-description, so for this branch, I would've called it something like ll_adapter-fix. Once you merge this in, remember to delete the branch 😄

Once you smoke test and address nit number 1, this can merge in! Nice work! 🚀

[alexjoel42]

Talked to @sanni-t and there is likely a future lift that's much more user friendly to go from the bed of the cylinders instead of the bottom of the modules due to how the Thermocycler is loaded onto the deck.

Flex now places the Thermocycler on the deck in a different way then the OT-2 so it's harder to measure from the bottom of the physical Thermocycler that's below the deck.

Magnetic Module

Stacking offset with module = Module height (to the top of the cylinder which is 38mm) + labware height - combined height from user input (z)

Thermocycler and Magnetic module files that are pulled from to get the "module height"

TC2

GEN1 Magnetic Block

Question we resolved.

moduleDefinition.dimensions.bareOverallHeight is not equal to the module height to the top of the cylinder. It's moduleDefinition.labwareOffset.z. Woo!

We're now within 0.1mm of one of our official labware and no longer negative and are getting the same adapter values. Going to test reservoirs for throughness and then call it.