Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code_platoon subpage and fix code review issues #1820

Merged
merged 1 commit into from
May 28, 2024

Conversation

kylemh
Copy link
Member

@kylemh kylemh commented May 28, 2024

Description of changes

  • Fix typo on /scholarship page
  • Fix visual alignment of scholarship options on /scholarship page
  • Add CP subpage

Issue Resolved

Fixes #1818

Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
operation-code ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:24pm
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 7:24pm

@kylemh
Copy link
Member Author

kylemh commented May 28, 2024

Copy link

codeclimate bot commented May 28, 2024

Code Climate has analyzed commit 96001a0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 81.2% (0.0% change).

View more on Code Climate.

@kylemh kylemh merged commit b5e93b3 into main May 28, 2024
18 checks passed
@kylemh kylemh deleted the scholarship-subpage-for-cp branch May 28, 2024 19:29
Copy link

cypress bot commented May 28, 2024

1 flaky test on run #4707 ↗︎

0 25 0 0 Flakiness 1

Details:

add code_platoon subpage and fix code review issues
Project: operation_code Commit: 96001a06c3
Status: Passed Duration: 03:14 💡
Started: May 28, 2024 7:26 PM Ended: May 28, 2024 7:29 PM
Flakiness  cypress/e2e/hashlink.spec.js • 1 flaky test • all tests

View Output Video

Test Artifacts
Hash Links > on About page > will change route when clicked Screenshots Video

Review all test suite changes for PR #1820 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New SubPage: Code Platoon x Operation Code Bootcamp Scholarship
1 participant