Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better press page #196

Merged
merged 36 commits into from
Oct 3, 2018
+828 −54
Merged

Better press page #196

Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
28d8c96
Better Styling for press page
dirtyredz Oct 3, 2018
608e1b8
Added 3 lists for the "In The News" section.
dirtyredz Oct 3, 2018
79b2ebc
Update Button test for onClick
dirtyredz Oct 3, 2018
7bcd8c4
Tests for PressLinks components
dirtyredz Oct 3, 2018
3e40e85
Merge from master
dirtyredz Oct 3, 2018
8201dea
Move PressLinks into Press
dirtyredz Oct 3, 2018
bbc413a
Use proper press import
dirtyredz Oct 3, 2018
dd5cae3
Ignore Links data structure
dirtyredz Oct 3, 2018
c8bf708
Merge branch 'master' into BetterPressPage
dirtyredz Oct 3, 2018
cd0ab2c
Merge branch 'master' into BetterPressPage
dirtyredz Oct 3, 2018
1c39db4
Merge branch 'master' into BetterPressPage
kylemh Oct 3, 2018
361aca7
Merge branch 'master' into BetterPressPage
kylemh Oct 3, 2018
4886c07
Merge branch 'master' into BetterPressPage
kylemh Oct 3, 2018
8c0728a
Merge branch 'master' into BetterPressPage
dirtyredz Oct 3, 2018
16cb650
Changes for project consistancy and readability
dirtyredz Oct 3, 2018
0945f7c
Press Articles readability, and fixed tests
dirtyredz Oct 3, 2018
b143fb4
Pass aria and data attributes to button
dirtyredz Oct 3, 2018
ed500fa
Nested Class instead of element class (still winning the war)
dirtyredz Oct 3, 2018
e53cabd
Using datum prop button
dirtyredz Oct 3, 2018
eab9302
Asc Order on objects
dirtyredz Oct 3, 2018
970e76b
Check if prop actually exists
dirtyredz Oct 3, 2018
c15cf7c
Moved ArticleItem to its own directory and renamed ArticleGroup
dirtyredz Oct 3, 2018
9a5f669
Use module resolved paths instead of relative paths
kylemh Oct 3, 2018
b9c0f9f
Rename component class
kylemh Oct 3, 2018
5ad37dc
Rename test suite
kylemh Oct 3, 2018
404d84b
Update ArticleGroup.test.js.snap
kylemh Oct 3, 2018
0c7d7e5
Dont use snapshot in data and aria testing
dirtyredz Oct 3, 2018
55e18a2
Use Region and Article for easier readability
dirtyredz Oct 3, 2018
7cc32a3
Remove dead comments and simplify rendering logic
kylemh Oct 3, 2018
5c34b9c
Specify disabled rule and use resolved path
kylemh Oct 3, 2018
fc0af68
Resolve lint error and rendering error
kylemh Oct 3, 2018
2ab4333
Put missing required prop in test case
kylemh Oct 3, 2018
5b08534
Retry the refactor 😅
kylemh Oct 3, 2018
dce7e88
Add required prop to <OutboundLink /> on <ArticleGroup />
kylemh Oct 3, 2018
03a1542
Updated Snap
dirtyredz Oct 3, 2018
cc2c97d
Merge branch 'master' into BetterPressPage
kylemh Oct 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into BetterPressPage
@kylemh
kylemh authored Oct 3, 2018
commit 1c39db472c593688ada101e4f96e0e170c844fef

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.