Fix 5141

[jgarte]

Closes #5141

[jcamiel]

Hi @jgarte thanks for the PR!

Everything is good except for the commit signatures: your commits have to be signed (there is so information on it in the CONTRIBUTING guide)

[jgarte]

Hi @jgarte thanks for the PR!

Everything is good except for the commit signatures: your commits have to be signed (there is so information on it in the CONTRIBUTING guide)

Hi @jcamiel Thanks for the review. I just force pushed signing the commits with my gpg signature. All best.

[jcamiel]

I'm sorry the commits still appear "Unverified"...

Can you check that "vigilant mode" in not activated in your settings? I've already seen this settings triggers the "Unverified" tag... Sorry for this

[jgarte]

Can you check that "vigilant mode" in not activated in your settings? I've already seen this settings triggers the "Unverified" tag... Sorry for this

I checked my settings and Vigilant Mode is disabled, so that's not the cause. I'll investigate why GitHub is marking these commits as unverified.

[jgarte]

Can you check that "vigilant mode" in not activated in your settings? I've already seen this settings triggers the "Unverified" tag... Sorry for this

I checked my settings and Vigilant Mode is disabled, so that's not the cause. I'll investigate why GitHub is marking these commits as unverified.

@jcamiel Looks like I signed the commits but I didn't upload my GPG public key to the GitHub settings admin area 🦆

It's uploaded now and the signatures are green.

[jcamiel]

Thanks, commits are OK, I've just missed something (that's why the CI is still red): along integration/hurl/tests_ok/post/post_bytes_null_curl.sh, you need to write a Powershell script integration/hurl/tests_ok/post/post_bytes_null_curl.ps1 that will be run on Windows. This is basically the same script as the .sh except the cat command.

Instead of

cat build/post_bytes_null.curl

You have to write:

Write-Host (Get-Content build/post_bytes_null.curl -Raw) -NoNewLine

[jgarte]

Thanks, commits are OK, I've just missed something (that's why the CI is still red): along integration/hurl/tests_ok/post/post_bytes_null_curl.sh, you need to write a Powershell script integration/hurl/tests_ok/post/post_bytes_null_curl.ps1 that will be run on Windows. This is basically the same script as the .sh except the cat command.

Instead of

cat build/post_bytes_null.curl

You have to write:

Write-Host (Get-Content build/post_bytes_null.curl -Raw) -NoNewLine

Added and force pushed @jcamiel Thanks for the review. I think you might have to retrigger CI in order to run it again and see it pass.

[jcamiel]

/accept

[hurl-bot]

🕗 /accept is running, please wait for completion.

[hurl-bot]

🔨 Auto rebase from Orange-OpenSource/hurl/master succeeds, jgarte/hurl/fix-5141-curl-nul-body now embeds these commits:

• feb08de Update crates
• b655615 Simplify Squid install for Windows
• b4396e5 Update crates
• 6268bd8 Update actions
• e11f20a Update crates
• aef9f8a Update crates
• fad458e Update crates
• 6ee18f5 Add integ test for max_redirect option in config file
• 27235a4 Add options retry/retry_interval in config_file
• af68b97 Add pretty option in config_file
• 36e683a Consume newline consistently
• 2edea43 Add no_header option in config_file
• ebf6200 Add no_cookie_store option in config_file
• f9552f8 Update crates
• 125f175 Update crates
• 03fcb84 Update Hurl npm packet dependencies.
• a72dfdb Update CHANGELOG.
• 4345483 Fix Issuer pattern for https://hurl.dev integration tests.
• 49f6788 Update crates
• 76caed6 Update crates
• ee57fd3 Add http3 option in config_file
• a2c72ca Fix Squid installation on Windows
• cdc06ae Add http2 option in config_file
• 1409b07 Add http1.0 option in config_file
• 558c5f8 Add http1.1 option in config_file
• fe7dd4d Add --variables-file per request option
• cb54bb6 Add user option in config_file
• f50728c Update CONTRIBUTING guide with AI tool use policy.
• 3c3149b Add --no-jsonpath-coercion in [Options] section
• 61c80bf Update to Rust 1.97.1
• 490f5e1 Update crates
• a4f547b Update Hurl npm package dependencies.
• 492ce76 Update crates
• aa4545a Fix typo.
• 7f3ec91 First version of a doc to change --file-root to --allow-read/--allow-write
• d59638a Update crates
• aa0b9b7 Update crates
• d92d926 Update crates
• 0b64f51 Update crates
• 7af20c8 Update Python dev dependencies
• 6391fb5 Update crates
• 82aee74 Update crates
• 7396485 Update actions
• a5b4d42 Update CHANGELOG.
• 1dc5fbc Update crates
• b163b3e Re-export Input struct from hurl_core to hurl.
• 9d68cd3 Add HURL_HTTP2_PRIOR_KNOWLEDGE env var configuration.
• 82d76fe Add --http2-prior-knowledge per request option.
• 31baad9 Add --http2-prior-knowledge command line option to use HTTP/2 without HTTP/1.1 Upgrade.
• 122f725 Update crates
• 8f23c91 Update changelog.
• b3394d2 Update crates
• 9b30335 Update actions
• ec5a202 Update crates
• df059d8 Update changelog.
• 67a705a Update crates
• 31a6b1a Add support for curl 8.21 - error output in proxy_port.err.pattern
• ef9f851 No more ci cache for vcpkg
• ed91c89 Fix stripping cookie from Cookies section when redirecting to a different host
• d7440b3 Update crates
• 878c59e Fix variable option values starting with a number or boolean
• 3fd6280 Update crates
• 276f277 Add HURL_PROXY_HEADER env var configuration.
• 5ee4e0f Update crates
• 10e53a2 Update actions

[hurl-bot]

🕗 /accept is still running, please wait for completion.

[hurl-bot]

❌ Some checks are still failing, please fix them before trying to merge this pull request.

[jgarte]

❌ Some checks are still failing, please fix them before trying to merge this pull request.

@jcamiel @hurl-bot

It's unclear to me which checks are still failing.

Is there a report somewhere that I can review?

[jcamiel]

Don't worry it's in our hand now. The bot rebases the PR so it can be merge with fast forward and it needs a confirmation to run for first-time contributors' PRs. I deal with it now everything is OK from your side and thanks again for the PR!

[jgarte]

Don't worry it's in our hand now. The bot rebases the PR so it can be merge with fast forward and it needs a confirmation to run for first-time contributors' PRs. I deal with it now everything is OK from your side and thanks again for the PR!

Ok, sounds good. Thanks for the reviews! All the best.

[jcamiel]

/accept

[hurl-bot]

🕗 /accept is running, please wait for completion.

[hurl-bot]

✅ Pull request merged with fast forward by jcamiel..

# List of commits merged from jgarte/hurl/fix-5141-curl-nul-body branch into Orange-OpenSource/hurl/master branch:

• dea947f Update changelog for Hurl debug curl command are not valid when request binary body contains NUL (\x00) char #5141.
• 66fae8f Add integration tests for curl command with NUL body.
• 685a417 Fix debug curl command when request body contains NUL byte.