Documentation improvements and fixes - #5206
Merged
Merged
Conversation
Collaborator
|
Hi @qligier thanks a lot for these fixes! |
Collaborator
|
/accept --force |
Collaborator
|
🕗 /accept --force is running, please wait for completion. |
It was previously removed from the docs in Orange-OpenSource@c0fdf6e and was never implemented.
All those predicates have a single whitespace (`sp`) allowed between the keyword and parameters, but `greater-or-equal-predicate` had `sp sp*`.
Collaborator
|
🔨 Auto rebase from
|
Collaborator
|
🕗 /accept --force is still running, please wait for completion. |
Collaborator
|
✅ Pull request merged with fast forward by
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
While implementing Hurlevent, I noticed a few things in the documentation that could be improved or fixed.
Commits are split to facilitate cherry-picking, if need be.
The grammar documentation wasn't regenerated after fe7dd4d, so changes related to
variables-file-optionappear in this diff.I also noticed that those changes didn't make it to the changelog, which made my work a bit harder:
decode(which has an impact on all users too)charsetEncode(since it was unimplemented, this one was certainly less important)