feat : component password input #398

Tayebsed93 · 2025-09-30T16:56:21Z

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#397

Description

Motivation & Context

Types of change

Bug fix (non-breaking which fixes an issue)
New feature (non-breaking change which adds functionality)
Refactoring (non-breaking change)
Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

I have read the contributing guidelines

Accessibility

My change follows accessibility good practices

Design

My change respects the design guidelines of Orange Unified Design System

Development

My change follows the developer guide
I have added unit tests to cover my changes (optional)

Documentation

My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

Manually test (dark mode, RTL, landscape display, tablet)
Documentation has been updated if relevant
Design review
A11y review
Internal files have been updated if relevant (THIRD_PARTY, NOTICE)
changelog.md has been updated respecting keep a changelog rules and referencing the issue

ouds_core/lib/components/form_input/internal/ouds_form_input_enum.dart

app/lib/ui/components/components.dart

app/lib/ui/components/form_input/form_fields_enum.dart

app/lib/ui/components/form_input/password_input/password_input_demo_screen.dart

app/lib/l10n/ouds_flutter_en.arb

app/lib/ui/utilities/customizable/customizable_textfield.dart

app/lib/ui/components/form_input/form_fields_customization.dart

ouds_core/lib/l10n/ouds_flutter_en.arb

AhmedAmineZr · 2025-10-10T10:42:49Z

@Tayebsed93 Bravo pour le travaille réalisé , j'ai quelque remarque de plus :
1- Quand on affiche le Password dans le 1er controller le 2éme doit suivre puisque :

2- dans les costumization on une valeur de Hidden Password qui manque dans le App , je sais que y a l'icône qui fait le même travaille mais je pense qu'on doit ajouté

Good Job

app/lib/l10n/gen/ouds_flutter_app_localizations_ar.dart

app/lib/l10n/gen/ouds_flutter_app_localizations_en.dart

Tayebsed93 · 2025-10-10T12:04:21Z

@Tayebsed93 Bravo pour le travaille réalisé , j'ai quelque remarque de plus : 1- Quand on affiche le Password dans le 1er controller le 2éme doit suivre puisque :

2- dans les costumization on une valeur de Hidden Password qui manque dans le App , je sais que y a l'icône qui fait le même travaille mais je pense qu'on doit ajouté

Good Job

@AhmedAmineZr Merci pour ta remarque. Nous n'avons pas pas de callback (car je n'en vois pas l'utilité); la lib est fermé donc on ne peux pas récupérer l'état du bouton (hidden/visible)
Je ne pense pas que ce soit utile d'ouvrir l'api

nouha06 · 2025-11-04T14:22:41Z

Merci pour ce travaille réaliser pour le composant
J’ai seulement quelques remarques mineures :
Ici, lorsqu’un utilisateur saisit un long texte dans le placeholder, le champ s’agrandit, mais lorsqu’il saisit son mot de passe, le champ reste étendu.

et les cas d'erreurs ne sont pas traiter dans app de demo? genre quand utilisateur saisie un mot de passe less than 8 characters ou quand il saisie un champs vide ...

ouds_core/lib/components/form_input/password_input/ouds_password_input.dart

app/lib/ui/components/form_input/text_input/text_input_demo_screen.dart

ouds_core/lib/l10n/ouds_flutter_ar.arb

ouds_core/lib/l10n/ouds_flutter_en.arb

ouds_core/lib/components/form_input/password_input/ouds_password_input.dart

nouha06 · 2025-11-04T15:19:37Z

Merci pour ce travaille réaliser pour le composant J’ai seulement quelques remarques mineures : Ici, lorsqu’un utilisateur saisit un long texte dans le placeholder, le champ s’agrandit, mais lorsqu’il saisit son mot de passe, le champ reste étendu.

et les cas d'erreurs ne sont pas traiter dans app de demo? genre quand utilisateur saisie un mot de passe less than 8 characters ou quand il saisie un champs vide ...

resolved

# Conflicts: # app/CHANGELOG.md # app/lib/l10n/gen/ouds_flutter_app_localizations.dart # app/lib/l10n/gen/ouds_flutter_app_localizations_ar.dart # app/lib/l10n/gen/ouds_flutter_app_localizations_en.dart # app/lib/l10n/ouds_flutter_ar.arb # app/lib/l10n/ouds_flutter_en.arb # app/lib/ui/components/components.dart # app/lib/ui/components/form_input/form_fields_customization_utils.dart # app/lib/ui/components/form_input/text_input/text_input_demo_screen.dart # app/lib/ui/utilities/customizable/customizable_textfield.dart # ouds_core/CHANGELOG.md # ouds_core/lib/components/form_input/ouds_text_input.dart # ouds_core/lib/l10n/gen/ouds_localizations.dart # ouds_core/lib/l10n/gen/ouds_localizations_ar.dart # ouds_core/lib/l10n/gen/ouds_localizations_en.dart # ouds_core/lib/l10n/ouds_flutter_ar.arb # ouds_core/lib/l10n/ouds_flutter_en.arb

…b.com/Orange-OpenSource/ouds-flutter into 397-create-component---password-input

Tayebsed93 self-assigned this Sep 30, 2025

Tayebsed93 added ⚛️ component 📱 demo app 🧰 library labels Sep 30, 2025

Tayebsed93 linked an issue Sep 30, 2025 that may be closed by this pull request

Create component - Password Input #397

Closed

Tayebsed93 changed the title ~~Component : Password input~~ feat : Component Password input Sep 30, 2025

Tayebsed93 changed the title ~~feat : Component Password input~~ feat : component password input Sep 30, 2025

Tayebsed93 force-pushed the 397-create-component---password-input branch 2 times, most recently from b949d71 to 97bec3c Compare October 3, 2025 16:12

Tayebsed93 marked this pull request as ready for review October 6, 2025 15:56

Tayebsed93 force-pushed the 397-create-component---password-input branch from 97bec3c to 7be6af8 Compare October 6, 2025 16:03

AhmedAmineZr self-requested a review October 7, 2025 12:49

AhmedAmineZr reviewed Oct 7, 2025

View reviewed changes

nouha06 self-requested a review October 8, 2025 07:49

nouha06 reviewed Oct 8, 2025

View reviewed changes

Tayebsed93 force-pushed the 397-create-component---password-input branch 4 times, most recently from 002d36a to 29db125 Compare October 9, 2025 11:18

AhmedAmineZr approved these changes Oct 10, 2025

View reviewed changes

app/lib/l10n/gen/ouds_flutter_app_localizations_ar.dart Outdated Show resolved Hide resolved

app/lib/l10n/gen/ouds_flutter_app_localizations_en.dart Outdated Show resolved Hide resolved

Tayebsed93 force-pushed the 397-create-component---password-input branch from 29db125 to 8f58a56 Compare October 10, 2025 12:05

Tayebsed93 added the ⌛ waiting for validations label Oct 15, 2025

Tayebsed93 force-pushed the 397-create-component---password-input branch 2 times, most recently from 69955ac to b70de8c Compare October 20, 2025 15:34

Tayebsed93 added the ⌛ validations awaiting fixes label Oct 20, 2025

Tayebsed93 added 3 commits November 4, 2025 11:41

first commit

06f725d

feat : add finish password input

3362f11

review : decoration / code generator / outlined

a483959

Tayebsed93 added 11 commits November 4, 2025 11:48

review : keys and fix trailing icon

e383c9a

review : max lines and component list

99c260c

review dart code generator

5a4abb7

review : add no doc l10n

5fbe909

review : keys l10n

815ddad

review : loader status

6dff48e

review : prefix status

6940a8e

fix : prefix and suffix status like password input

df4fa2b

fix: build function Textfield

4039716

chore : add customizable textfield

df16617

fix: order component name alphabetic

ce37daa

Tayebsed93 force-pushed the 397-create-component---password-input branch from 3548aa4 to ce37daa Compare November 4, 2025 10:58

nouha06 reviewed Nov 4, 2025

View reviewed changes

nouha06 and others added 9 commits November 4, 2025 17:13

review: accessibility, token text color

0f2776d

review: accessibility

50c03cc

review : order component

f0c5697

loader when placeholder and typing

123475d

Merge branch 'develop' into 397-create-component---password-input

9843642

review: loader state disabled edditing

3eb07b0

Merge branch '397-create-component---password-input' of https://githu…

e33af20

…b.com/Orange-OpenSource/ouds-flutter into 397-create-component---password-input

review : changelog

67a0293

Tayebsed93 merged commit 711b276 into develop Nov 6, 2025
3 checks passed

Tayebsed93 deleted the 397-create-component---password-input branch November 6, 2025 14:59

feat : component password input #398

feat : component password input #398

Uh oh!

Conversation

Tayebsed93 commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issues

Description

Motivation & Context

Types of change

Previews

Checklist

Contribution

Accessibility

Design

Development

Documentation

Checklist (for Core Team only)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AhmedAmineZr commented Oct 10, 2025

Uh oh!

Uh oh!

Uh oh!

Tayebsed93 commented Oct 10, 2025

Uh oh!

nouha06 commented Nov 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nouha06 commented Nov 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Tayebsed93 commented Sep 30, 2025 •

edited

Loading