-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Use a rootless hardened docker image #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,3 +4,4 @@ backend/.env | |
| frontend/node_modules | ||
| frontend/dist | ||
| frontend/.tanstack | ||
| *.exe | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| package hub | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "os" | ||
| "runtime" | ||
| ) | ||
|
timokoessler marked this conversation as resolved.
|
||
|
|
||
| func initDataDir() error { | ||
| if err := os.MkdirAll("data", 0750); err != nil { | ||
| return err | ||
| } | ||
| return checkDataDirWritable() | ||
| } | ||
|
|
||
| func checkDataDirWritable() error { | ||
| return checkWritable("data") | ||
| } | ||
|
|
||
| func checkWritable(dir string) error { | ||
| f, err := os.CreateTemp(dir, ".write-check-*") | ||
| if err == nil { | ||
| err = f.Close() | ||
| if err != nil { | ||
| return err | ||
| } | ||
| err = os.Remove(f.Name()) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| return nil | ||
| } | ||
| if !os.IsPermission(err) { | ||
| return err | ||
| } | ||
| if runtime.GOOS == "windows" { | ||
| return fmt.Errorf("directory is not writable, check the folder permissions") | ||
| } | ||
| return fmt.Errorf( | ||
| "directory is not writable, run: sudo chown -R %d:%d ./data", | ||
| os.Getuid(), os.Getgid(), | ||
| ) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package hub | ||
|
|
||
| import ( | ||
| "os" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestCheckWritable_WritableDir(t *testing.T) { | ||
| dir := t.TempDir() | ||
| if err := checkWritable(dir); err != nil { | ||
| t.Fatalf("expected nil for writable directory, got %v", err) | ||
| } | ||
| } | ||
|
|
||
| func TestCheckWritable_NonExistentDir(t *testing.T) { | ||
| err := checkWritable(t.TempDir() + "/does-not-exist") | ||
| if err == nil { | ||
| t.Fatal("expected error for non-existent directory, got nil") | ||
| } | ||
| if os.IsPermission(err) { | ||
| t.Errorf("expected a non-permission error for missing directory, got: %v", err) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| //go:build !windows | ||
|
|
||
| package hub | ||
|
|
||
| import ( | ||
| "os" | ||
| "strings" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestCheckWritable_ReadOnlyDir(t *testing.T) { | ||
| if os.Getuid() == 0 { | ||
| t.Skip("skipping: chmod has no effect when running as root") | ||
| } | ||
| dir := t.TempDir() | ||
| if err := os.Chmod(dir, 0o400); err != nil { | ||
| t.Fatalf("chmod: %v", err) | ||
| } | ||
| // Restore before t.TempDir cleanup so the directory can be removed. | ||
| // t.Cleanup runs in LIFO order, so this runs before the TempDir cleanup. | ||
| t.Cleanup(func() { | ||
| if err := os.Chmod(dir, 0o700); err != nil { //nolint:gosec // restore perms so t.TempDir cleanup can remove it | ||
| t.Errorf("cleanup chmod: %v", err) | ||
| } | ||
| }) | ||
|
|
||
| err := checkWritable(dir) | ||
| if err == nil { | ||
| t.Fatal("expected error for read-only directory, got nil") | ||
| } | ||
| if !strings.Contains(err.Error(), "not writable") { | ||
| t.Errorf("error %q does not contain expected message", err) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.