feat: Key-Rotate command - #205
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Hub CLI surface for rotating the database encryption key (derived from APP_SECRET) by re-encrypting all encrypted DB fields using a provided previous secret, with confirmation prompts, demo-mode blocking, and unit tests to validate rotation behavior.
Changes:
- Register a new
hub keycommand group with arotatesubcommand. - Implement key rotation logic to re-encrypt encrypted fields across Agents, Applications, Repositories, Notifications, and OIDC providers within a DB transaction.
- Add unit tests covering successful re-encryption, invalid secret validation, and command wiring.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| backend/cmd/hub/main.go | Registers the new key command with the Hub CLI root command. |
| backend/cmd/hub/key_rotate.go | Implements hub key rotate, including secret validation, confirmation flow, DB connection, transactional re-encryption, and result rendering. |
| backend/cmd/hub/key_rotate_test.go | Adds tests for rotation correctness and secret validation behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alex289
enabled auto-merge (squash)
June 20, 2026 10:32
timokoessler
approved these changes
Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hub key rotatecommand to re-encrypt database fields from an oldAPP_SECRETto the current one.Testing
Fixes #167