Skip to content

fix(restore): stop containers with resolved compose stack - #2900

Open
patil2001 wants to merge 1 commit into
Osmantic:mainfrom
patil2001:fix/bk/restore-stop
Open

fix(restore): stop containers with resolved compose stack#2900
patil2001 wants to merge 1 commit into
Osmantic:mainfrom
patil2001:fix/bk/restore-stop

Conversation

@patil2001

Copy link
Copy Markdown
Contributor

Summary

stop_containers ran a bare docker compose down, but the repo ships no
top-level compose file, so -s/--stop-containers always failed with "no
configuration file provided" and the restore ran under live writes. Add
resolve_compose_flags and use it, mirroring ods-uninstall.sh.

AI Assistance

Written with an AI pair; reviewed and tested on this machine.

Release Lane

  • Stable hotfix targeting release/2.6.x
  • Mainline change targeting main
  • Next-minor work targeting the next feature/minor release
  • Not sure; reviewer should help classify

Changed Surface

  • Docs only
  • Tests only
  • Dashboard UI
  • Dashboard API / host agent
  • Installer / bootstrap / lifecycle
  • Docker Compose / service manifests
  • Model routing / Hermes / capabilities
  • Network exposure / auth / proxy
  • Dependencies / runtime wiring

Risk And Validation

  • Risk level: Medium
  • Validation run:
    • git diff --check
    • Focused tests listed below

Commands/results:

�[0;32m\u2713�[0m resolve_compose_flags returns the resolved compose stack

Operational Change Check

  • This is an operational change and validation is recorded above.

stop_containers ran a bare `docker compose down`, but the repo ships no
top-level compose file, so -s/--stop-containers always failed with "no
configuration file provided" and the restore ran under live writes. Add
resolve_compose_flags and use it, mirroring ods-uninstall.sh.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant