fix(installer): detect stale background-task pids - #2901
Open
patil2001 wants to merge 1 commit into
Open
Conversation
bg_task_status used os.kill(pid,0) alone, which only proves some process owns the number: a reaped and recycled pid is reported running, so bg_task_wait spins to its 1200s timeout instead of completing. Record the process start time at registration and only treat a live pid as the task when its start time still matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bg_task_status used os.kill(pid,0) alone, which only proves some process
owns the number: a reaped and recycled pid is reported running, so
bg_task_wait spins to its 1200s timeout instead of completing. Record the
process start time at registration and only treat a live pid as the task
when its start time still matches.
AI Assistance
AI helped draft; I reviewed every hunk and ran the checks below.
Release Lane
release/2.6.xmainChanged Surface
Risk And Validation
git diff --checkCommands/results:
Operational Change Check