Skip to content

fix(installer): strip quotes when reading env values on macOS - #2902

Open
patil2001 wants to merge 1 commit into
Osmantic:mainfrom
patil2001:fix/bk3/env-read-quotes
Open

fix(installer): strip quotes when reading env values on macOS#2902
patil2001 wants to merge 1 commit into
Osmantic:mainfrom
patil2001:fix/bk3/env-read-quotes

Conversation

@patil2001

Copy link
Copy Markdown
Contributor

Summary

read_env_value left surrounding double-quotes intact while sibling helpers stripped them, breaking == "cloud" / == "true" gates on quoted values.

AI Assistance

AI-assisted; reviewed and verified locally before opening.

Release Lane

  • Stable hotfix targeting release/2.6.x
  • Mainline change targeting main
  • Next-minor work targeting the next feature/minor release
  • Not sure; reviewer should help classify

Changed Surface

  • Docs only
  • Tests only
  • Dashboard UI
  • Dashboard API / host agent
  • Installer / bootstrap / lifecycle
  • Docker Compose / service manifests
  • Model routing / Hermes / capabilities
  • Network exposure / auth / proxy
  • Dependencies / runtime wiring

Risk And Validation

  • Risk level: Low
  • Validation run:
    • git diff --check
    • Not required because: narrow change; syntax and diff checks pass locally

Commands/results:

git diff --check clean; bash -n on touched scripts passes

Operational Change Check

  • This is an operational change and validation is recorded above.

read_env_value left surrounding double-quotes intact while sibling helpers stripped them, breaking == "cloud" / == "true" gates on quoted values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant