feat(observability): expose dashboard API metrics - #2906
Open
tang-vu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
The dashboard API is the control plane for setup, model, extension, and health operations, but operators cannot scrape its own request rate or latency. This adds a dependency-free Prometheus endpoint that supports alerting and capacity diagnosis while deliberately labeling by FastAPI route template instead of raw URL, preventing extension/model IDs from creating unbounded time series.
Overlap check
Searched open and closed upstream PRs for
Prometheus dashboard API,metrics endpoint,observability, and all changed production files. Closed PRs #1761/#1822 test and harden parsing of llama-server metrics; #2128 enables llama.cpp metrics on Windows. None instrument dashboard-api HTTP traffic. Open PRs #2731, #2736, and #2819 touchmain.pyfor CSRF, key lifecycle, and Docker-probe fixes respectively; their behavior and test surfaces are independent from this middleware and/metricsroute.What changed
GET /metricsin Prometheus 0.0.4 text format/metricsscrapes from observationsfinallyboundary without swallowing exceptionsRegression test
python -m pytest -q tests/test_api_metrics.pyAlso validated:
python -m pytest -q tests/test_api_metrics.py tests/test_main.py(77 passed)python -m py_compile api_metrics.py main.py tests/test_api_metrics.pygit diff --check