Skip to content

fix(dashboard): clean error when model record lacks gguf_file #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patil2001 wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −2
Open

fix(dashboard): clean error when model record lacks gguf_file #2920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ods/extensions/services/dashboard-api/routers/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1961,8 +1961,12 @@ def download_model(model_id: str, api_key: str = Depends(verify_api_key)):
detail={**bootstrap_conflict, "requestedModelId": model_id},
)

gguf_file = model.get("gguf_file")
if not gguf_file:
raise HTTPException(status_code=404, detail=f"Model '{model_id}' is missing a GGUF file reference")

payload = {
"gguf_file": model["gguf_file"],
"gguf_file": gguf_file,
"gguf_url": model.get("gguf_url", ""),
"gguf_sha256": model.get("gguf_sha256", ""),
}
Expand Down Expand Up @@ -2066,8 +2070,12 @@ def delete_model(model_id: str, api_key: str = Depends(verify_api_key)):
if model is None:
raise HTTPException(status_code=404, detail=f"Model '{model_id}' not found in library or local GGUF files")

gguf_file = model.get("gguf_file")
if not gguf_file:
raise HTTPException(status_code=404, detail=f"Model '{model_id}' is missing a GGUF file reference")

payload = {
"gguf_file": model["gguf_file"],
"gguf_file": gguf_file,
}
if model.get("gguf_parts"):
payload["gguf_parts"] = model["gguf_parts"]
Expand Down
24 changes: 24 additions & 0 deletions ods/extensions/services/dashboard-api/tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2655,3 +2655,27 @@ def test_load_model_rejects_local_gguf_path_separators(test_client, monkeypatch,
)

assert resp.status_code == 404


def test_download_and_delete_reject_library_record_missing_gguf_file(test_client, monkeypatch, tmp_path):
models_router, install_dir, data_dir = _patch_model_router_paths(monkeypatch, tmp_path)
_write_model_library(install_dir, [{"id": "legacy-model", "name": "Legacy Model"}])
monkeypatch.setattr(
models_router,
"_call_agent_model",
lambda *_args, **_kwargs: (_ for _ in ()).throw(
AssertionError("host agent reached for record without gguf_file")
),
)

download_response = test_client.post(
"/api/models/legacy-model/download",
headers=test_client.auth_headers,
)
delete_response = test_client.delete(
"/api/models/legacy-model",
headers=test_client.auth_headers,
)

assert download_response.status_code == 404
assert delete_response.status_code == 404
Loading