Skip to content

test(ci): guard claude-review PR-head checkout logic - #2923

Open
patil2001 wants to merge 2 commits into
Osmantic:mainfrom
patil2001:fix/claude-review-pr-ref
Open

test(ci): guard claude-review PR-head checkout logic#2923
patil2001 wants to merge 2 commits into
Osmantic:mainfrom
patil2001:fix/claude-review-pr-ref

Conversation

@patil2001

Copy link
Copy Markdown
Contributor

Summary

test(ci): guard claude-review PR-head checkout logic.

AI Assistance

AI-assisted; reviewed and verified locally before opening.

Release Lane

  • Stable hotfix targeting release/2.6.x
  • Mainline change targeting main
  • Next-minor work targeting the next feature/minor release
  • Not sure; reviewer should help classify

Changed Surface

  • Docs only
  • Tests only
  • Dashboard UI
  • Dashboard API / host agent
  • Installer / bootstrap / lifecycle
  • Docker Compose / service manifests
  • Model routing / Hermes / capabilities
  • Network exposure / auth / proxy
  • Dependencies / runtime wiring

Risk And Validation

  • Risk level: Low
  • Validation run:
    • git diff --check
    • Focused tests listed below

Commands/results:

Result: 6 passed, 0 failed

Operational Change Check

  • This is not an operational change.

On issue_comment events github.ref points at the default branch and
github.base_ref is empty, so checkout fetched main and the review silently
reviewed main instead of the PR head. Check out the PR merge ref
(refs/pull/N/merge) on the issue_comment path and diff HEAD^...HEAD for
the size check, while keeping the existing pull_request behavior and the
fork guard unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant