Make it work on aarch64 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refered here for similar issue: skade/leveldb#32 * manually cherrypicked the change from: gwsystems@906d483
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I manually incorporated that single change from gwsystems/llvm-rs. I'm thinking the build failures you have had are because of 1. I also changed another dependency to be using gwsystems and perhaps that commit head needs an update in the cargo files, 2. you've a number of other changes beyond that which are not incorporated in to that gwsystems/llvm-rs. So!
Heads up, this specific PR is not tested, I just collected that change I had "working" from my previous tests in Sledge work and put them here.
If you do approve this PR, do you mind updating the cargo files in aWsm compiler to include this? Though this is not going to impact a lot of you I think yet, and we likely are going to wait to update commit heads of this in the serverless works, so not high a priority if you'd rather want to wait and remove these dependencies entirely!