Repository navigation
Conversation
|
| if (parsed.columnId) { | ||
| this.accessKeyDataSortColumnId = parsed.columnId; | ||
| } | ||
| if (parsed.sortDirection) { | ||
| this.accessKeyDataSortDirection = parsed.sortDirection; |
There was a problem hiding this comment.
If an update removes or renames a sortable column, _restoreAccessKeySortPreference() still applies its saved name. The table then shows the keys unsorted without clearing that choice. Check the saved column and direction before applying them, and use a default when either is no longer valid.
Knowledge Base Used: Server operations console
| ready() { | ||
| super.ready(); | ||
|
|
||
| this._restoreAccessKeySortPreference(); |
There was a problem hiding this comment.
The new save-and-restore path has no test for reopening the Manager or keeping two servers’ choices separate. Add coverage for both flows so a later change to view startup or server selection does not silently undo this feature.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
Closes #1909
Access-key table sort (column + direction) reset every time the Manager was reopened.
localStorage, keyed per server id.Test plan