Skip to content

feat(manager): persist access-key table sort preference - #2885

Open
whoalin1 wants to merge 1 commit into
OutlineFoundation:masterfrom
whoalin1:feat/persist-access-key-sort
Open

whoalin1 wants to merge 1 commit into
OutlineFoundation:masterfrom
whoalin1:feat/persist-access-key-sort

Conversation

@whoalin1

@whoalin1 whoalin1 commented Oct 7, 2026

Copy link
Copy Markdown

Summary

Closes #1909

Access-key table sort (column + direction) reset every time the Manager was reopened.

  • Persist sort column id and direction in localStorage, keyed per server id.
  • Restore the preference when the server view becomes ready.
  • Update the stored preference whenever the user changes sort.

Test plan

  • Open a server, sort keys by name or data used
  • Quit / reload Manager → same sort is applied for that server
  • Sorting another server does not overwrite the first server's preference

@whoalin1
whoalin1 requested a review from a team as a code owner October 7, 2026 02:25
@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

[Low risk] Saves table sort preference to browser storage.

The PR appears safe to merge, with a fallback for stale saved values and tests worth adding.

Findings

  1. P2 Old sort choices stop working ▶
  2. P2 Saved sorts lack tests ▶

Summary

The Outline Manager now remembers the access-key table’s sort column and direction for each server. It saves the choice in localStorage and restores it when the server view becomes ready.

  • The access-key table keeps its sort for each server.

Reviews (1) · Last reviewed commit: "feat(manager): persist access-key table ..." · Reviewed by Greptile

Comment on lines +746 to +750
if (parsed.columnId) {
this.accessKeyDataSortColumnId = parsed.columnId;
}
if (parsed.sortDirection) {
this.accessKeyDataSortDirection = parsed.sortDirection;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Old sort choices stop working

If an update removes or renames a sortable column, _restoreAccessKeySortPreference() still applies its saved name. The table then shows the keys unsorted without clearing that choice. Check the saved column and direction before applying them, and use a default when either is no longer valid.

Knowledge Base Used: Server operations console

ready() {
super.ready();

this._restoreAccessKeySortPreference();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Saved sorts lack tests

The new save-and-restore path has no test for reopening the Manager or keeping two servers’ choices separate. Add coverage for both flows so a later change to view startup or server selection does not silently undo this feature.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve key list sorting setting in Manager

1 participant