Repository navigation
fix(client/electron): handle EPIPE on stdout and stderr to prevent crash on Linux - #2894
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
[Medium impact] The PR appears safe to merge. SummaryAdds error listeners to
Reviews (1) · Last reviewed commit: "fix(client/electron): handle EPIPE on st..." · Reviewed by Greptile |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux desktop environments, launching the Outline client from a terminal and subsequently closing that terminal breaks the stdout and stderr pipes. Any subsequent write to
process.stdoutorprocess.stderr(e.g. fromconsole.logor child process output) throws an unhandledEPIPEerror, causing the Electron main process to crash fatally.This change adds error event listeners on both
process.stdoutandprocess.stderrinclient/electron/index.tsto silently swallowEPIPEerrors while re-throwing any other unexpected stream errors.Fixes OUTLINE-CLIENTS-NF7VF
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry at no cost. You can adjust this setting at any time.