Skip to content

Standalone distribution - Slf4j Logging #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmontuelle wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Standalone distribution - Slf4j Logging #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions oxalis-ng-dist/oxalis-ng-standalone/src/main/java/network/oxalis/ng/Main.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,21 +241,21 @@ public static void main(String[] args) throws Exception {

for (TransmissionResult transmissionResult : results) {
TransmissionIdentifier transmissionIdentifier = transmissionResult.getTransmissionIdentifier();
System.out.println(String.format("%s transmission took %s ms",
transmissionIdentifier, transmissionResult.getDuration()));
log.info("{} transmission took {} ms",
transmissionIdentifier, transmissionResult.getDuration());
}

OptionalDouble average = results.stream().mapToLong(TransmissionResult::getDuration).average();

if (average.isPresent()) {
System.out.println("Average transmission time was " + average.getAsDouble() + "ms");
log.info("Average transmission time was {}ms", average.getAsDouble());
}
long elapsedInSeconds = TimeUnit.SECONDS.convert(elapsed, TimeUnit.NANOSECONDS);
System.out.println("Total time spent: " + elapsedInSeconds + "s");
System.out.println("Attempted to send " + results.size() + " files");
System.out.println("Failed transmissions: " + failed);
if (results.size() > 0 && elapsedInSeconds > 0) {
System.out.println("Transmission speed " + results.size() / elapsedInSeconds + " documents per second");
log.info("Total time spent: {}s", elapsedInSeconds);
log.info("Attempted to send {} files", results.size());
log.info("Failed transmissions: {}", failed);
if (!results.isEmpty() && elapsedInSeconds > 0) {
log.info("Transmission speed {} documents per second", results.size() / elapsedInSeconds);
}

// Sleep if set to do so.
Expand Down
4 changes: 1 addition & 3 deletions oxalis-ng-dist/oxalis-ng-standalone/src/main/java/network/oxalis/ng/TransmissionTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,7 @@ protected TransmissionRequest createTransmissionRequest() {
return requestBuilder.build();
} catch (Exception e) {
span.setAttribute("exception", String.valueOf(e.getMessage()));
System.out.println();
System.out.println("Message failed : " + e.getMessage());
System.out.println();
log.error("Message failed ", e);
return null;
}
});
Expand Down