Typehints and debug messages - #66
Open
danielwbn wants to merge 3 commits into
Open
Conversation
dnadlinger
reviewed
Mar 3, 2026
| from wand.tools import LaserOwnedException, LockException | ||
|
|
||
| if TYPE_CHECKING: | ||
| from frontend.wand_server import WandServer |
Member
There was a problem hiding this comment.
This should at least be wand.frontend.wand_server, though really, the better solution would probably be to break the cyclic dependency.
Member
|
Sorry, this won't merge cleanly now anymore given the transition to Ruff, but you can just |
Correct the import statement for WandServer to include the proper frontend module path for type checking.
Contributor
Author
|
I fixed the merge conflicts. Love the new ruff formatting and -conda +uv changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No functional changes, just add a few type hints and debug log messages.
In some cases, the check of the result of a wlm library call is delayed until the result has been logged.
Tested on Ubuntu 22.04.5, python 3.10.12, HighFinesse WS8