Skip to content

fix(EM-1799): drop just inactive enum choices #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2025
Merged

fix(EM-1799): drop just inactive enum choices #21

merged 3 commits into from
Jul 8, 2025

Conversation

@hugo07E8
Copy link
Contributor

@hugo07E8 hugo07E8 commented Jun 30, 2025 •
edited
Loading

  • Remove length from isEmpty. This made the code enter a condition that removed all the options and set a plain "0".
  • Update unit tests.

@hugo07E8 hugo07E8 marked this pull request as draft June 30, 2025 20:30
doneill
doneill reviewed Jul 1, 2025
View reviewed changes
doneill
doneill reviewed Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@doneill doneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be moved out of draft as the fix is required to ensure we don't use isEmpty() on length property

@hugo07E8 hugo07E8 self-assigned this Jul 2, 2025
@hugo07E8 hugo07E8 marked this pull request as ready for review July 2, 2025 20:41
doneill
doneill approved these changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator

@doneill doneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work 👍

@doneill doneill added B - Ready To Merge PR is ready to be merged and removed B - Waiting for review labels Jul 8, 2025
@hugo07E8 hugo07E8 merged commit e0d614d into develop Jul 8, 2025
2 checks passed
@doneill doneill deleted the bug/EM-1799-fix-inactive-enum-choices branch July 16, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doneill doneill doneill approved these changes

@gabyledesma gabyledesma gabyledesma approved these changes

@leo-ori leo-ori Awaiting requested review from leo-ori leo-ori is a code owner

@Alex79373 Alex79373 Awaiting requested review from Alex79373 Alex79373 is a code owner

Assignees

@hugo07E8 hugo07E8

Labels

B - Ready To Merge PR is ready to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugo07E8 @doneill @gabyledesma