Skip to content

fix(EM-1788): display checkbox in fieldset #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

fix(EM-1788): display checkbox in fieldset #22

merged 1 commit into from
Jul 11, 2025

Conversation

@hugo07E8
Copy link
Contributor

@hugo07E8 hugo07E8 commented Jul 2, 2025 •
edited
Loading

  • Add support for displaying check boxes inside field sets.
  • Add tests to validate the changes on the JSON schema.
  • Add tests to validate the changes on the UI schema.

@hugo07E8 hugo07E8 self-assigned this Jul 2, 2025
@hugo07E8 hugo07E8 marked this pull request as draft July 2, 2025 20:11
@hugo07E8 hugo07E8 marked this pull request as ready for review July 2, 2025 20:17
doneill
doneill approved these changes Jul 11, 2025
View reviewed changes
Copy link
Collaborator

@doneill doneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work 👍

@doneill doneill added B - Ready To Merge PR is ready to be merged and removed B - Waiting for review labels Jul 11, 2025
@doneill doneill merged commit 74c464b into develop Jul 11, 2025
2 checks passed
@doneill doneill deleted the bug/EM-1788-checkbox-fieldset branch July 16, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doneill doneill doneill approved these changes

@gabyledesma gabyledesma gabyledesma approved these changes

@leo-ori leo-ori Awaiting requested review from leo-ori leo-ori is a code owner

@Alex79373 Alex79373 Awaiting requested review from Alex79373 Alex79373 is a code owner

Assignees

@hugo07E8 hugo07E8

Labels

B - Ready To Merge PR is ready to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugo07E8 @doneill @gabyledesma