Fix presence detection for multiple windows/tabs/devices #576
+171
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #575
Each tab/window maintains its own separate websocket connection. We were storing a single rtdb path for a user. If a user opened two windows, then closed one, the onDisconnect handler would be called, switching the user to offline even though they still had an open window.
This PR fixes that, by using an rtdb path with a unique id for each connection. The trigger aggregates all documents for a given user to determine if they are online or not. There's also now a scheduled job that removes old records every 72 hours.
I don't know if this fixes every issue with presence detection, but it definitely fixes an issue.
This PR will have a small conflict with #572, since that one moves some of the code that temporarily disables presence detection. So if merging both of them, make sure to update #572 to remove that code (there won't necessarily be a merge conflict).