Only show API keys for experiment if current viewer is the creator #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivtsai
requested review from
aldenhallak and
cjqian
and removed request for
cjqian
Collaborator
|
Looks good! Could you add a screenshot of it in action? |
aldenhallak
approved these changes
Nov 4, 2025
frontend/src/components/experimenter/experimenter_data_editor.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing API key panel in experiment builder and experiment dashboard, show a message about the experiment creator's keys being used instead of showing the current experimenter's keys (which is inaccurate).
API.key.fix.demo.webm
This PR fixes: #664