Do not use input to set access-key #288
Open
+55
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
ihrasko
requested changes
Sep 12, 2025
ihrasko
requested changes
Sep 12, 2025
Tobianas
force-pushed
the
addPersistancePublish
branch
from
57816e4 to
6f5ad00
Compare
Correct the GitHub Actions workflow to use docker/login-action@v3 for proper authentication to GitHub Container Registry. Previously, the workflow attempted to pass the token directly via docker login, causing authentication failures. JIRA: LIGHTY-385 Signed-off-by: tobias.pobocik [email protected] Signed-off-by: tobias.pobocik <[email protected]>
Tobianas
force-pushed
the
addPersistancePublish
branch
from
6f5ad00 to
89b8f0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous approach did not work because:
-GHCR requires a PAT to push images, and publish-access-key which defaults to "default", is not a valid token.
-secrets.MM_PKG_WRITE was not used in login step, instead it was only used in env.
JIRA: LIGHTY-385