Skip to content

Sync dependencies with odlparent 14.0.9 #2229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ihrasko merged 4 commits into from
Jun 2, 2025
Merged

Sync dependencies with odlparent 14.0.9 #2229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a77777c
Bump awaitility to 4.3.0
Tobianas Jun 2, 2025
22301e6
Bump checkstyle to 10.23.0
Tobianas Jun 2, 2025
48aed23
Bump JUnit to 5.12.1
Tobianas Jun 2, 2025
8d6cc03
Bump maven-{surefire,failsafe}-plugin to 3.5.3
Tobianas Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lighty-core/dependency-versions/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@
<dependency>
<groupId>org.junit</groupId>
<artifactId>junit-bom</artifactId>
<version>5.12.0</version>
<version>5.12.1</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand All @@ -146,7 +146,7 @@
<dependency>
<groupId>org.awaitility</groupId>
<artifactId>awaitility</artifactId>
<version>4.2.2</version>
<version>4.3.0</version>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
Expand Down
6 changes: 3 additions & 3 deletions lighty-core/lighty-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,12 +115,12 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
<version>3.5.2</version>
<version>3.5.3</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.5.2</version>
<version>3.5.3</version>
<configuration>
<forkCount>1</forkCount>
<reuseForks>true</reuseForks>
Expand Down Expand Up @@ -192,7 +192,7 @@
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<!-- This should match the dependency management on com.puppycrawl.tools:checkstyle above -->
<version>10.21.4</version>
<version>10.23.0</version>

@gemini-code-assist gemini-code-assist Bot Jun 2, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This update changes the com.puppycrawl.tools:checkstyle version (used as a dependency by maven-checkstyle-plugin) to 10.23.0. This version aligns with what is specified in odlparent 14.0.9, which is good.

However, there's a nuance regarding the comment on the preceding line (194): <!-- This should match the dependency management on com.puppycrawl.tools:checkstyle above -->.

Currently, the project imports org.opendaylight.odlparent:odlparent:pom:14.0.8 (in lighty-core/dependency-versions/pom.xml), which manages com.puppycrawl.tools:checkstyle at version 10.21.4.
By explicitly setting the version here to 10.23.0, you are correctly using the newer version intended by odlparent 14.0.9, but it means this version overrides the (older) managed version. This makes the comment on line 194 potentially less clear or accurate if "dependency management above" refers to the effective managed version from the 14.0.8 BOM.

For full consistency and to ensure the project truly syncs with odlparent 14.0.9:

  1. The org.opendaylight.odlparent:odlparent BOM import in lighty-core/dependency-versions/pom.xml should be updated to 14.0.9 (as highlighted in the general PR feedback).
  2. This would ensure com.puppycrawl.tools:checkstyle is managed at 10.23.0 by default, making the comment on line 194 accurate without needing an explicit version here (or this explicit version would match the new managed version).
  3. Additionally, the org.opendaylight.odlparent:checkstyle artifact dependency (currently on line 205, version 14.0.8) should be updated to 14.0.9 to use the checkstyle rules corresponding to odlparent 14.0.9.

While this specific version change to 10.23.0 is correct in isolation for the tool, the broader context of the odlparent synchronization (especially updating the main BOM import) is crucial.

</dependency>
<dependency>
<groupId>com.github.sevntu-checkstyle</groupId>
Expand Down
2 changes: 1 addition & 1 deletion lighty-examples/lighty-controller-springboot-netconf/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.5.2</version>
<version>3.5.3</version>
<configuration>
<forkCount>1</forkCount>
<reuseForks>true</reuseForks>
Expand Down
Loading