Bump log4j-api to 2.25.0#2246
Conversation
Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-api from 2.24.3 to 2.25.0. https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.25.0 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the project's log4j-api dependency to version 2.25.0. This is a routine dependency bump, likely initiated by an automated tool like Snyk, to ensure the project benefits from the latest improvements, bug fixes, and security enhancements provided by the Log4j library.
Highlights
- Dependency Upgrade: Upgraded the
log4j-apidependency version from2.24.3to2.25.0.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request, created by Snyk, aims to upgrade org.apache.logging.log4j:log4j-api from 2.24.3 to 2.25.0 by updating the log4j2.version property. My review identifies a critical issue: the target version 2.25.0 is not yet available in public Maven repositories. This will cause the build to fail. I have recommended using the latest published version, 2.24.1, instead.
| <!-- Overrides Spring Boot slf4j and log4j2 dependency version --> | ||
| <slf4j.version>2.0.17</slf4j.version> | ||
| <log4j2.version>2.24.3</log4j2.version> | ||
| <log4j2.version>2.25.0</log4j2.version> |
There was a problem hiding this comment.
The specified Log4j2 version 2.25.0 is not available in public Maven repositories like Maven Central. This will cause the build to fail with dependency resolution errors.
Please use a version that has been published to Maven Central. The latest stable version available is 2.24.1.
<log4j2.version>2.24.1</log4j2.version>
3 participants
Snyk has created this PR to upgrade org.apache.logging.log4j:log4j-api from 2.24.3 to 2.25.0.
https://github.com/apache/logging-log4j2/releases/tag/rel%2F2.25.0