Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lighty-core/lighty-controller-spring-di/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-dependencies</artifactId>
<version>3.5.10</version>
<version>3.5.11</version>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability and to ensure version consistency across modules, it's recommended to use a property for the Spring Boot version. This property should be defined in a common parent pom.xml. This avoids hardcoding the version number in multiple places, making future updates easier and less error-prone.

Suggested change
<version>3.5.11</version>
<version>${spring-boot.version}</version>

<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<parent>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-parent</artifactId>
<version>3.5.10</version>
<version>3.5.11</version>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability and to ensure version consistency across modules, it's recommended to use a property for the Spring Boot version. This property should be defined in a common parent pom.xml if this module is part of a multi-module build. This avoids hardcoding the version number in multiple places, making future updates easier and less error-prone.

Suggested change
<version>3.5.11</version>
<version>${spring-boot.version}</version>

<relativePath/> <!-- lookup parent from repository -->
</parent>

Expand Down
Loading