-
Notifications
You must be signed in to change notification settings - Fork 2
[Feat/#144] Google 로그인 연동 #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6680f9c
feature/#144: img, icon 추가
vvan2 a7d2300
feature/#144: module 및 권한 수정
vvan2 adbdb8b
feature/#144: data/google login 로직 수정
vvan2 47bab9d
feature/#144: domain/google login 수정
vvan2 405884d
feature/#144: module 수정
vvan2 3a89b41
feature/#144: navigation 수정
vvan2 7b3cf3c
feature/#144: login UI 수정 및 Google 로그인 연동
vvan2 8d962ac
feature/#144: 온보딩 UI 수정
vvan2 8ed228c
feature/#144: 코드리뷰 대응
vvan2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,12 +7,8 @@ import com.google.android.libraries.identity.googleid.GetGoogleIdOption | |
| import com.google.android.libraries.identity.googleid.GoogleIdTokenCredential | ||
| import com.paw.key.BuildConfig | ||
| import com.paw.key.core.util.suspendRunCatching | ||
| import com.paw.key.data.dto.request.LoginRequestDto | ||
| import com.paw.key.data.dto.response.BaseResponse | ||
| import com.paw.key.data.dto.response.LoginResponseDto | ||
| import com.paw.key.data.remote.datasource.login.AuthRemoteDataSource | ||
| import com.paw.key.data.remote.datasource.login.GoogleAuthDataSource | ||
| import com.paw.key.data.service.login.LoginService | ||
| import timber.log.Timber | ||
| import javax.inject.Inject | ||
|
|
||
| class GoogleAuthDataSourceImpl @Inject constructor( | ||
|
|
@@ -22,7 +18,6 @@ class GoogleAuthDataSourceImpl @Inject constructor( | |
| suspendRunCatching { | ||
| val googleIdOption = GetGoogleIdOption.Builder() | ||
| .setFilterByAuthorizedAccounts(false) | ||
| .setAutoSelectEnabled(false) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 혹시 요거는 왜 지우셨을까요? 이유가 있을까요?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이것도 위와 같은 이유인데, 등록된 계정만 가능할 수 있게? 해준다해서 세팅하다가.. 다시 돌려놓겠습니다 |
||
| .setServerClientId(BuildConfig.GOOGLE_WEB_CLIENT_ID) | ||
| .build() | ||
|
|
||
|
|
@@ -32,5 +27,6 @@ class GoogleAuthDataSourceImpl @Inject constructor( | |
|
|
||
| val response = credentialManager.getCredential(context, request) | ||
| GoogleIdTokenCredential.createFrom(response.credential.data) | ||
|
|
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 추가한 이유있을까요? 구글 로그인 만이면 굳이 핸드폰 자체의 계정까지 가져오지 않아도 되고 GoogleSignInClient으로 대체된 것으로 알아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 초기에 구글 로그인 연동 때, 오류 나서 이것 저것 시도했던 흔적이.. 남아 있네요. Client id 문제였던걸로 해결됐으니, 삭제하겠습니다!