Skip to content

Broken Github Issues links on games containing '&' #561

Description

@pektezol

Games containing '&' in the title e.g Ratchet & Clank has its Github Issues link broken. By broken, I mean that you get directed to the Github Issues page, but the filter is wrong since the '&' can't get parsed from the URL. The fix is to transform & into %26.

Current Github Issues link for Ratchet & Clank: https://github.com/PCSX2/pcsx2/issues?q=is:issue%20SCES-50916%20OR%20%22Ratchet%20&%20Clank%22

Image

Working Github Issues link for Ratchet & Clank: https://github.com/PCSX2/pcsx2/issues?q=is%3Aissue%20SCES-50916%20OR%20%22Ratchet%20%26%20Clank%22

> src/pages/compat/index.js

          <Tooltip content={"GitHub Issues"} placement={"left"}>
            <Link
              href={encodeURI(
                `https://github.com/PCSX2/pcsx2/issues?q=is:issue ${entry.serial} OR "${entry.title}"`,
              )}
              target="_blank"
              rel="noopener noreferrer"
            >
              <FaGithub size={22}></FaGithub>
            </Link>
          </Tooltip>

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions